From owner-freebsd-acpi@FreeBSD.ORG Mon Sep 8 22:20:04 2008 Return-Path: Delivered-To: freebsd-acpi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA9C01065675 for ; Mon, 8 Sep 2008 22:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DB4328FC17 for ; Mon, 8 Sep 2008 22:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m88MK4Ap053460 for ; Mon, 8 Sep 2008 22:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m88MK4TA053459; Mon, 8 Sep 2008 22:20:04 GMT (envelope-from gnats) Date: Mon, 8 Sep 2008 22:20:04 GMT Message-Id: <200809082220.m88MK4TA053459@freefall.freebsd.org> To: freebsd-acpi@FreeBSD.org From: Pietro Cerutti Cc: Subject: Re: kern/124223: [acpi] [patch] acpi_battery.c -- Notify user-defined critical level via devd(8) X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Pietro Cerutti List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2008 22:20:05 -0000 The following reply was made to PR kern/124223; it has been noted by GNATS. From: Pietro Cerutti To: Nate Lawson Cc: bug-followup@FreeBSD.org, freebsd-acpi@FreeBSD.org Subject: Re: kern/124223: [acpi] [patch] acpi_battery.c -- Notify user-defined critical level via devd(8) Date: Tue, 09 Sep 2008 00:14:14 +0200 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Nate Lawson wrote: | Pietro Cerutti wrote: |> Nate Lawson wrote: |> | There are a few problems with your approach. |> | |> | Critical status is already reported with a flag when usermode polls for |> | the battery status: |> |> if (sc->bst.state & ACPI_BATT_STAT_CRITICAL) { |> |> if ((sc->flags & ACPI_BATT_STAT_CRITICAL) == 0) { |> |> sc->flags |= ACPI_BATT_STAT_CRITICAL; |> |> device_printf(dev, "critically low charge!\n"); |> |> } |> |> } |> |> I agree. Critical level is already checked for in the cmbat module. |> However, reporting is not done in a "standardized" way. My patch would |> just like to add notification through devd. | | But it doesn't just add notification through devd. It adds a thread, | that separately polls for battery state and sends a notify through devd. | If the user is running any battery app, there's a double poll for the | same info. | | I subscribe to the design approach that where it makes sense to do | something in usermode, don't do it in kernel mode. In this case, the IO | interface is poll-only, and any user app that is running can set its own | policy for how to deal with the information it gets from polling. [snip xbatt-related stuff] | Let's keep this in usermode, where policy belongs. That's fine. Thanks for reviewing that! Best, - -- Pietro Cerutti gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEAREKAAYFAkjFo7UACgkQwMJqmJVx945TJQCfTRuG0ZiMSfyIaw0rb/5C1cXY E4oAoJdERo/AA7KwGRtYnVEQeUoPo9Az =UAwz -----END PGP SIGNATURE-----