Date: Wed, 5 Feb 2020 16:09:20 +0000 (UTC) From: Kyle Evans <kevans@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r525282 - in head/emulators: qemu-sbruno qemu-user-static-devel Message-ID: <202002051609.015G9KAY027713@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kevans (src committer) Date: Wed Feb 5 16:09:19 2020 New Revision: 525282 URL: https://svnweb.freebsd.org/changeset/ports/525282 Log: qemu-user-static: revert SSP_CFLAGS workaround (ports r501032) This was later diagnosed to be a bug in libc, which has since been addressed in all supported releases and branches. PORTREVISION is bumped as SSP_CFLAGS will change the output, and for consumers of these two ports it is imperative that it be rebuilt against the updated libc to avoid high failure rates. In testing qemu-user-static-devel failed roughly 60% of the time, rendering it unusable as each fork/exec was yet one more chance to fail. The bug was fixed in the following patch levels (FreeBSD-EN-20:01.ssp): - 12.1-p2 - 12.0-p13 - 11.3-p6 PR: 243735 Approved by: koobs (ports) MFH: 2020Q1 Modified: head/emulators/qemu-sbruno/Makefile head/emulators/qemu-user-static-devel/Makefile Modified: head/emulators/qemu-sbruno/Makefile ============================================================================== --- head/emulators/qemu-sbruno/Makefile Wed Feb 5 16:06:31 2020 (r525281) +++ head/emulators/qemu-sbruno/Makefile Wed Feb 5 16:09:19 2020 (r525282) @@ -3,7 +3,7 @@ PORTNAME= qemu PORTVERSION= 2.11.50.g20191211 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= emulators PKGNAMESUFFIX?= -sbruno DIST_SUBDIR= qemu/${PORTVERSION} @@ -131,7 +131,6 @@ PLIST_SUB+= SOFTMMU="" PLIST_SUB+= STATIC="" .endif -SSP_CFLAGS?= -fstack-protector # XXX -strong crashes qemu-user-static WITHOUT_CPU_CFLAGS=yes #to avoid problems with register allocation CFLAGS:= ${CFLAGS:C/-fno-tree-vrp//} CFLAGS+= -Wno-address-of-packed-member Modified: head/emulators/qemu-user-static-devel/Makefile ============================================================================== --- head/emulators/qemu-user-static-devel/Makefile Wed Feb 5 16:06:31 2020 (r525281) +++ head/emulators/qemu-user-static-devel/Makefile Wed Feb 5 16:09:19 2020 (r525282) @@ -2,7 +2,7 @@ PORTNAME= qemu PORTVERSION= 3.1.0 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= emulators PKGNAMESUFFIX= -user-static-devel DIST_SUBDIR= qemu/${PORTVERSION} @@ -47,7 +47,6 @@ PLIST_SUB+= 64BIT="@comment " .endif CONFIGURE_ARGS+= --target-list=${QEMU_TARGETS:ts,} -SSP_CFLAGS?= -fstack-protector # XXX -strong crashes qemu-user-static WITHOUT_CPU_CFLAGS=yes #to avoid problems with register allocation CFLAGS:= ${CFLAGS:C/-fno-tree-vrp//} CFLAGS+= -Wno-address-of-packed-member
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202002051609.015G9KAY027713>