From owner-cvs-src@FreeBSD.ORG  Fri Jan  4 17:50:43 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 764F616A46B;
	Fri,  4 Jan 2008 17:50:43 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net
	[66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 010A613C4D3;
	Fri,  4 Jan 2008 17:50:41 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: (from root@localhost)
	by kientzle.com (8.12.9/8.12.9) id m04HofEr004084;
	Fri, 4 Jan 2008 09:50:41 -0800 (PST)
	(envelope-from kientzle@freebsd.org)
Received: from [10.0.0.209] (p54.kientzle.com [66.166.149.54])
	by kientzle.com with SMTP; Fri, 04 Jan 2008 09:50:41 -0800 (PST)
	(envelope-from kientzle@freebsd.org)
Message-ID: <477E71F1.4080301@freebsd.org>
Date: Fri, 04 Jan 2008 09:50:41 -0800
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Dag-Erling Smorgrav <des@freebsd.org>
References: <200801031830.m03IUb9K049549@repoman.freebsd.org>
In-Reply-To: <200801031830.m03IUb9K049549@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/lib/libarchive archive_endian.h
	archive_read_support_format_zip.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2008 17:50:43 -0000

Dag-Erling Smorgrav wrote:
> des         2008-01-03 18:30:37 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libarchive       archive_read_support_format_zip.c 
>   Added files:
>     lib/libarchive       archive_endian.h 
>   Log:
>   Crib {be,le}{16,32,64}{dec,enc} from src/sys/sys/endian.h and use it instead
>   of home-rolled [iu][248] in the ZIP support code.
>   
>   Approved by:    kientzle
>   
>   Revision  Changes    Path
>   1.1       +142 -0    src/lib/libarchive/archive_endian.h (new)
>   1.19      +22 -57    src/lib/libarchive/archive_read_support_format_zip.c

Is this really right?

> +be32dec(const void *pp)
> +{
> +       unsigned char const *p = (unsigned char const *)pp;

The "const *" is harmless enough, but dropping the
leading "const" doesn't seem right at all:  'pp'
is a pointer to const data, 'p' points to
modifiable data.

Tim Kientzle