Date: Sat, 16 Feb 2019 00:53:21 +0000 From: bugzilla-noreply@freebsd.org To: scsi@FreeBSD.org Subject: [Bug 229551] src/sys/dev/trm/trm.c:2484: bad if logic Message-ID: <bug-229551-5313-os9uytkOQS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-229551-5313@https.bugs.freebsd.org/bugzilla/> References: <bug-229551-5313@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229551 Andriy Voskoboinyk <avos@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |avos@freebsd.org Status|New |Open Keywords| |patch Assignee|bugs@FreeBSD.org |scsi@FreeBSD.org --- Comment #1 from Andriy Voskoboinyk <avos@freebsd.org> --- I assume that (pDCB->DevMode & TAG_QUEUING_) && (pDCB->DevMode & EN_DISCONNECT_) should be changed to ((pDCB->DevMode & TAG_QUEUING_) || (pDCB->DevMode & EN_DISCONNECT_)) however, I don't think this fix should be committed to the tree without tes= ting with real device and / or specs verification. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229551-5313-os9uytkOQS>