From owner-freebsd-hackers  Thu May 25  7:42:32 2000
Delivered-To: freebsd-hackers@freebsd.org
Received: from numeri.campus.luth.se (numeri.campus.luth.se [130.240.197.103])
	by hub.freebsd.org (Postfix) with ESMTP id 8942D37C30E
	for <hackers@FreeBSD.ORG>; Thu, 25 May 2000 07:42:21 -0700 (PDT)
	(envelope-from k@numeri.campus.luth.se)
Received: from numeri.campus.luth.se (localhost [127.0.0.1])
	by numeri.campus.luth.se (8.9.3/8.9.3) with ESMTP id QAA12958;
	Thu, 25 May 2000 16:46:51 +0200 (CEST)
	(envelope-from k@numeri.campus.luth.se)
Message-Id: <200005251446.QAA12958@numeri.campus.luth.se>
X-Mailer: exmh version 2.1.1 10/15/1999
To: Alexander Langer <alex@big.endian.de>
Cc: hackers@FreeBSD.ORG
Subject: Re: review request: truncate(1) 
In-reply-to: Your message of "Thu, 25 May 2000 14:18:17 +0200."
             <20000525141817.A17484@cichlids.cichlids.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 25 May 2000 16:46:51 +0200
From: Johan Karlsson <k@numeri.campus.luth.se>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

At Thu, 25 May 2000 14:18:17 +0200, Alexander Langer wrote:
>Hello!
>
>I've written the command-line frontend to truncate(2).
>I've often needed that since now, and finally I wrote it.
>
>I'm sure it's useful.
>
>Please review (includes source, manpage + Makefile).
>
>http://big.endian.de/FreeBSD/truncate.tar.gz
>
>Thanks
>

Hi
Please sort the options in getopt and in the switch-statement.

see style(9) for more style info.


Please also use -Wall when compiling to catch all warnings
(add 
CFLAGS += -Wall
to your Makefile).


/Johan K


>Alex
>-- 
>I need a new ~/.sig.
>
>
>To Unsubscribe: send mail to majordomo@FreeBSD.org
>with "unsubscribe freebsd-hackers" in the body of the message
>




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message