Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Dec 2022 16:30:44 +0100
From:      Mathieu Arnold <mat@freebsd.org>
To:        Po-Chuan Hsieh <sunpoet@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 0e6cbfa14a8e - main - Mk/bsd.ruby.mk: Consolidate RUBY_PORTEPOCH
Message-ID:  <20221230153044.45nlgt7yxzknipcy@aching.in.mat.cc>
In-Reply-To: <202212300918.2BU9IkSm027533@gitrepo.freebsd.org>
References:  <202212300918.2BU9IkSm027533@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--e5jfbnqkozz5ttde
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

I don't really see the point of this, when a ruby port is will be
upgraded and then rolled back, you will have to revert this so that the
offending port can have its own PORTEPOCH.

On Fri, Dec 30, 2022 at 09:18:46AM +0000, Po-Chuan Hsieh wrote:
> The branch main has been updated by sunpoet:
>=20
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3D0e6cbfa14a8e8d9a2052f28d=
d6f7cf272cf7cc94
>=20
> commit 0e6cbfa14a8e8d9a2052f28dd6f7cf272cf7cc94
> Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> AuthorDate: 2022-12-30 08:55:14 +0000
> Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> CommitDate: 2022-12-30 09:06:32 +0000
>=20
>     Mk/bsd.ruby.mk: Consolidate RUBY_PORTEPOCH
>    =20
>     RUBY_PORTEPOCH is identical for all ruby ports (lang/rubyXX).
> ---
>  Mk/bsd.ruby.mk | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>=20
> diff --git a/Mk/bsd.ruby.mk b/Mk/bsd.ruby.mk
> index dcb8b6e52b14..a9a6ce42574e 100644
> --- a/Mk/bsd.ruby.mk
> +++ b/Mk/bsd.ruby.mk
> @@ -134,7 +134,6 @@ RUBY?=3D			${LOCALBASE}/bin/ruby${RUBY_SUFFIX}
>  #
>  RUBY_DISTVERSION=3D	2.7.7
>  RUBY_PORTREVISION=3D	0
> -RUBY_PORTEPOCH=3D		1
> =20
>  .      elif ${RUBY_VER} =3D=3D 3.0
>  #
> @@ -142,14 +141,12 @@ RUBY_PORTEPOCH=3D		1
>  #
>  RUBY_DISTVERSION=3D	3.0.5
>  RUBY_PORTREVISION=3D	0
> -RUBY_PORTEPOCH=3D		1
>  .      elif ${RUBY_VER} =3D=3D 3.1
>  #
>  # Ruby 3.1
>  #
>  RUBY_DISTVERSION=3D	3.1.3
>  RUBY_PORTREVISION=3D	0
> -RUBY_PORTEPOCH=3D		1
> =20
>  .      elif ${RUBY_VER} =3D=3D 3.2
>  #
> @@ -157,7 +154,6 @@ RUBY_PORTEPOCH=3D		1
>  #
>  RUBY_DISTVERSION=3D	3.2.0
>  RUBY_PORTREVISION=3D	0
> -RUBY_PORTEPOCH=3D		1
> =20
>  # When adding a version, please keep the comment in
>  # Mk/bsd.default-versions.mk in sync.
> @@ -168,6 +164,7 @@ RUBY_PORTEPOCH=3D		1
>  IGNORE=3D	Only ruby 2.7, 3.0, 3.1 and 3.2 are supported
>  _INVALID_RUBY_VER=3D	1
>  .      endif
> +RUBY_PORTEPOCH=3D		1
>  RUBY_VERSION=3D	${RUBY_DISTVERSION:C/^([0-9]+\.[0-9]+\.[0-9]+).*/\1/}
>  .    endif # defined(RUBY_VER)
> =20
>=20

--=20
Mathieu Arnold

--e5jfbnqkozz5ttde
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmOvBCRfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1
NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d
Qb7RKAwAkHcd2H/w+qY0woZLdonheOSJT8B1WekKrM4uSIpB9FSpIH3Fp+5mruuF
a2trDEOWYjRN6Dl3naFQgRlaNc5PrU7o9vK70JRK5b2/+rWwpFbCCzNge906yIVS
Uejo4QuPUkJC61AMYpyPtF4MLqpSjtDHP7Q5zypU1FbYxAtlMWj2r4L/+46DUmaX
7oKG7O9/B+VWnJFdoxeGHrbhlLugr/bH9kOvqOY+c4IZQBHIA8h5K1RWlIwcVShZ
OFk0xCdqnYSY7V6haWtkg/Fxk5iJtozaItO9kgPVwCtIP941XFeMNx1D3TOLKwvx
B6Tq8Q9GR3S5cryg01QqI54L+m523QxFFoT7Dq6+kzx2Nhzf/qVVX/mVO08jBZcr
yoG0bkY3zpgPeGB+wTH/TBuApKL8675y9NlYW3PNDC3Bda9HY5xAngzU5Wi6XdRz
PMcfEr6FUPyG0lY7n5PikrM+jpjV8Lxc0A+HP0dJOVfBSXxIYmS0RjaZ7igvkMAZ
RN2ClD05
=xFP4
-----END PGP SIGNATURE-----

--e5jfbnqkozz5ttde--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20221230153044.45nlgt7yxzknipcy>