From owner-cvs-ports@FreeBSD.ORG Mon Dec 5 09:36:29 2005 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D924616A41F; Mon, 5 Dec 2005 09:36:29 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED0A843D5A; Mon, 5 Dec 2005 09:36:28 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id jB59aSHb068808; Mon, 5 Dec 2005 01:36:28 -0800 (PST) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id jB59aQoC068799; Mon, 5 Dec 2005 01:36:26 -0800 (PST) (envelope-from obrien) Date: Mon, 5 Dec 2005 01:36:26 -0800 From: "David O'Brien" To: Florent Thoumie Message-ID: <20051205093626.GA68544@dragon.NUXI.org> References: <200511301510.jAUFACmr038837@repoman.freebsd.org> <20051130161657.GA65549@FreeBSD.org> <1133371126.1219.23.camel@cream.xbsd.org> <20051130183717.GA71920@xor.obsecurity.org> <1133380999.1219.30.camel@cream.xbsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=unknown-8bit Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1133380999.1219.30.camel@cream.xbsd.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.11 Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev , ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway Subject: Re: cvs commit: ports/shells/bash Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2005 09:36:30 -0000 On Wed, Nov 30, 2005 at 08:03:19PM +0000, Florent Thoumie wrote: > Le Mercredi 30 novembre 2005 à 13:37 -0500, Kris Kennaway a écrit : > > On Wed, Nov 30, 2005 at 05:18:46PM +0000, Florent Thoumie wrote: > > > Le Mercredi 30 novembre 2005 ?? 16:16 +0000, Alexey Dokuchaev a ??crit : > > > > On Wed, Nov 30, 2005 at 03:10:12PM +0000, Florent Thoumie wrote: > > > > > flz 2005-11-30 15:10:12 UTC > > > > > > > > > > FreeBSD ports repository > > > > > > > > > > Modified files: > > > > > shells/bash Makefile > > > > > Log: > > > > > - Add WANT_STATIC_BASH knob. > > > > > > > > WANT_ prefix belongs to bpm's internal namespace; it should not be used > > > > this way. > > > > > > Agreed, Pav made the same notice but : > > > > > > 1) that's not my port and, > > > > Don't commit bogus changes, and > > > > > 2) shells/bash2 has the same exact construction. > > > > fix bogus changes when you encounter them. > > I'll send a PR with s/WANT/WITH/ later and will commit the fix > in two weeks with maintainer timeout. *sigh* why all the overhead? Since you're already in the middle of this issue, please make it right for our users and just commit the fixed version now. -- -- David (obrien@FreeBSD.org) Q: Because it reverses the logical flow of conversation. A: Why is top-posting (putting a reply at the top of the message) frowned upon?