From nobody Tue Oct 7 14:10:19 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cgyhd4KLLz6BMJx for ; Tue, 07 Oct 2025 14:10:25 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cgyhd03gKz3P8j for ; Tue, 07 Oct 2025 14:10:25 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-x834.google.com with SMTP id d75a77b69052e-4dc4afb9e1cso67022571cf.0 for ; Tue, 07 Oct 2025 07:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759846223; x=1760451023; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=hgU9gTOk5G/KNjGSMCiGW9c7/TNElF2YRrpHGAI4Mkg=; b=FhNZ4JtW1DiRSoHkbxYj1OCrXRVItrbfivTXvvP0tNT3xqtmdr7mEJ2JAQxN0MyjdZ kPrK7x+7OfOuGi6k6vapvrxg/cInWnLrKayuiw033Xt4NpAGmGdTmgAHVyNdEusPKakW +3wfm2fROXbSrYS4Kc/Rc5Oq//53rGHioMPi+1aEiwWWlp8EkGPGIjv3oS8/R/YWOuJe 2fa7VLPipQmAUmpe/CUh3g6eBCRQgenIM7k4Jr0NJadBS0kzKtdxkwHtGb+Vf5i40/22 OtLL30Lcfpy1E+LSVDsqIOCmaU0fl0XdJvWg6roHe8lwenHal67FUR0u6ezQBX6XgqRm HpIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759846223; x=1760451023; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hgU9gTOk5G/KNjGSMCiGW9c7/TNElF2YRrpHGAI4Mkg=; b=LBlWNVA7Yjfx1SLwii1jMR9NFAemgUwtmf/iiM080JD74XDeoc3tFVCGQqzcIhw15b 2NffJcLhMUvOjwPdqAYv+iMdPlUO3ekAknEOUwVhPxavKlm8eboUxuOaJ7WTEAyxzG9k /LcdvB1tP2DBtuOlS1I1ScfShQo8R2o7qm0M/enjhkvGFK/l6U2bqm0rq+eD8ZAePwhU iVpuFd4il2QyQcU6152aqxholRezZPIItyjncxM4uqFYy9uVvecxV6DNDDFopzXbsw9l btAYwItImwHXejiRo5hbNe9zb23hDKwASLvZZZ1uHzaHejRbCCbUSv5IOqYAiarJMTrT hS4A== X-Forwarded-Encrypted: i=1; AJvYcCXmJnawXNdTrbSqGbCICdr/ko3fm/jvB2LqLXYgAeOPhf9q9Ii0IaQxzvvpa4HKErkzf7MIxJdQLbfBgCtqz7Week676g==@freebsd.org X-Gm-Message-State: AOJu0YwsTR8E5GaxrcadgmmDPRSJoE1scX0npBzzjS0gGdRP/nXX3+p+ SOyByKjp9zNfHHV1ADha/y4TdNlgTCQ86pabjRaB9SAlWjy//AKDaDIU X-Gm-Gg: ASbGncvY3lGmkgSek6a+gJHW/aczthOrzqR9yWTn5RURQoLvlZvR4SiJC2ziiSc5l1Z kuE1wwEtwyOOAbTARHeupnViqji0rh0ufOdvZupVClxClDs3AFh7YW03qkxkpKz/inAwm5qSFBx 2JNcW7AZoPF8QxQTeRKJ3T6LXLqWmWmettOA0PNGWtEDt4eQ10tLuO57GhjFP9eQEBaKjafXAH1 h7lAJfSpfEKLbaDhn5SzWhucinsN295zwLHHhLMffGCKf7ZtulqUUcBOxoyk1knUl53AzX25b1x IbOwYCHTo6xNRbUOq+drff4Y1deyvSBxSJZXMnPyEOrzwwShhplgxMGbqhCCww8yCpoA7KjnRr/ u1gHR6rlVcL125uRwHWmQc4iqxWY0tmi9viY/LKWbAy19nijio2n3cwB1y3Ed X-Google-Smtp-Source: AGHT+IHIWBIoQ9MBqSdG0nQXCIFLfycADhsuw4fXD6xJj81imQNRM8moF0kXLmiXGF+Ldk5pEQ1byg== X-Received: by 2002:ac8:5990:0:b0:4b6:18ff:3630 with SMTP id d75a77b69052e-4e6de868742mr46650171cf.24.1759846222470; Tue, 07 Oct 2025 07:10:22 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4e55d0cb747sm138340461cf.40.2025.10.07.07.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 07:10:22 -0700 (PDT) Date: Tue, 7 Oct 2025 10:10:19 -0400 From: Mark Johnston To: Christos Margiolis Cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, 0mp@freebsd.org Subject: Re: git: 9cab9fde5eda - main - virtual_oss: Port to base Message-ID: References: <202509280958.58S9wrww083342@gitrepo.freebsd.org> <861pnf83kw.fsf@ltc.des.dev> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cgyhd03gKz3P8j On Tue, Oct 07, 2025 at 03:48:26PM +0200, Christos Margiolis wrote: > On Tue Oct 7, 2025 at 11:26 AM CEST, Dag-Erling Smørgrav wrote: > > Christos Margiolis writes: > >> libexec/rc/rc.d/virtual_oss | 119 + > > > > This contains a reference to a non-existent sndiod service. > > I am aware. I discussed this with 0mp@ during EuroBSDCon in Zagreb and > decided that it probably does not hurt too much to leave it there, at > least for now. Well, it'll break the test added in https://reviews.freebsd.org/D52954, which will be useful for catching bugs. > It's important to note that for most users sndiod actually is not > needed. This is only needed when virtual_oss(8) runs with sndio support, > which has been moved to a new port: audio/virtual_oss_sndio. Why not just modify the sndiod script to REQUIRE virtual_oss?