From nobody Mon Dec 5 14:11:09 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NQlpK2c5vz4jpJR; Mon, 5 Dec 2022 14:11:21 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NQlpJ4JqKz3PGg; Mon, 5 Dec 2022 14:11:20 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1670249472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8juF+M0SDs+CZ0wxwx+r12B2E48adGAdfIzz9AL4fHU=; b=aGhOPKWwT9bOw+S9xWgE2s3jTnsQscWLz9v5ly8ivZll9iPlwINP0fkFasfw5/itFXV1OY CJJarTcy0cMZ6sl2xqaol5TfxYTPpZoc32FT1vScAwCTRNRdipiPSNxPyWaTZkqoUg5zbT OO0Rf7I53/n86yEdrQNifPJ37wYyT9w= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id e5c83eb7 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 5 Dec 2022 14:11:12 +0000 (UTC) Date: Mon, 5 Dec 2022 15:11:09 +0100 From: Emmanuel Vadot To: Dmitry Marakasov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 3f78a234e458 - main - graphics/gpu-firmware-kmod: optionize firmware vendors Message-Id: <20221205151109.e86a24dd8a15bb2ae5d55756@bidouilliste.com> In-Reply-To: References: <202211291718.2ATHISXL015063@gitrepo.freebsd.org> <20221130111151.bbdc3e3b221207cb541daccd@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4NQlpJ4JqKz3PGg X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Hi Dmitry, On Mon, 5 Dec 2022 16:35:00 +0300 Dmitry Marakasov wrote: > * Emmanuel Vadot (manu@bidouilliste.com) wrote: > > > > The branch main has been updated by amdmi3: > > > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3f78a234e45851fc57d23bd86b6362671244ecc6 > > > > > > commit 3f78a234e45851fc57d23bd86b6362671244ecc6 > > > Author: Dmitry Marakasov > > > AuthorDate: 2022-11-15 20:18:39 +0000 > > > Commit: Dmitry Marakasov > > > CommitDate: 2022-11-29 17:18:21 +0000 > > > > > > graphics/gpu-firmware-kmod: optionize firmware vendors > > > > > > PR: 267796 > > > Approved by: maintainer timeout (x11, 2 weeks) > > > --- > > > graphics/gpu-firmware-kmod/Makefile | 34 ++++++++++++++++++++++++---------- > > > 1 file changed, 24 insertions(+), 10 deletions(-) > > > > > > > Sorry, I've missed this PR. > > I don't really understand the point of this. > > This is a meta port that should always build everything, it's mostly > > made for the end package users so every package is available > > You don't need to include a package into a metapackage to make it > available ) Sorry I don't follow. > > and also so > > user who doesn't know which firmware they needs can just pkg install > > this package. If you already know which firmware you need you can just > > pkg install it (or just build it from ports/poudriere). > > This is not true because drm-kmod unconditionally pulls > gpu-firmware-kmod which unconditionally pulls all the firmwares. drm-kmod meta-port is made for two reasons : - Users don't know what hardware they have so a simple pkg install drm-kmod will install everything. - Downstream distribution that wants to include everything a user can have. If you know what hardware you have it's better to directly install drm-510-kmod and gpu-firmware--kmod- packages. > > It's a bit unlikely that one user will need only all > > the radeon/amd/intel firmwares. > > Well in fact there should be an option for each individual firmware, > but I was lazy. No there shouldn't be an option for each firmware, each firmware is a separate flavor of the main vendor port and this result in a dedicated package for one GPU. (There is one cavehat for AMD, see below). > Another valid case is that I have no idea which specific > intel firmware I need, I just don't want nvidia/amd garbage. Yes this is one problem, I've pondered writing a fwget script to put in base that will solve this issue, will probably do it one day. For intel it's kinda easy, just install drm-510-kmod, kldload i915kms and look in dmesg what firmware the driver says it couldn't load. DRM will work for intel without firmware, you just can't suspend/resume. For AMD depending on the GPUs sometimes it will work without a firmware, sometime it will not, meaning that you will lose the screen and will need to use serial/ssh (unless it bricks the machine but if that does it this is a bug that should be solved). Some generations of AMD gpu needs two firmware packages, this is because AMD reuse some IP (most of the time it's the VCN, the unit for video decoding/encoding) that is re-used. -- Emmanuel Vadot