From owner-freebsd-usb@FreeBSD.ORG  Mon Aug 11 13:40:04 2008
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 325DE106564A
	for <freebsd-usb@hub.freebsd.org>; Mon, 11 Aug 2008 13:40:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 20DC28FC12
	for <freebsd-usb@hub.freebsd.org>; Mon, 11 Aug 2008 13:40:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m7BDe3dl067506
	for <freebsd-usb@freefall.freebsd.org>; Mon, 11 Aug 2008 13:40:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m7BDe3gh067505;
	Mon, 11 Aug 2008 13:40:03 GMT (envelope-from gnats)
Date: Mon, 11 Aug 2008 13:40:03 GMT
Message-Id: <200808111340.m7BDe3gh067505@freefall.freebsd.org>
To: freebsd-usb@FreeBSD.org
From: Kai Wang <kaiwang27@gmail.com>
Cc: 
Subject: Re: kern/123510: [ums] Mouse Wheel Fails to Work [regression]
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Kai Wang <kaiwang27@gmail.com>
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Aug 2008 13:40:04 -0000

The following reply was made to PR kern/123510; it has been noted by GNATS.

From: Kai Wang <kaiwang27@gmail.com>
To: bug-followup@FreeBSD.org, tmdraney@verizon.net
Cc:  
Subject: Re: kern/123510: [ums] Mouse Wheel Fails to Work [regression]
Date: Mon, 11 Aug 2008 15:10:01 +0200

 Hello Merritt,
 
 Since /usr/src/sys/dev/usb/ums.c rev 1.96.2.1 worked for you, I guess
 this might be caused by rev 1.97 which removed "TWHEEL" stuff.
 
 Could you please try the patch below and see if it also fix the
 problem?
 (Patch should apply to latest -STABLE or -CURRENT)
 
 Thanks,
 Kai
 
 
 
 --- /sys/dev/usb/ums.c	2008-05-05 20:25:42.000000000 +0200
 +++ ums.c.new	2008-08-11 15:00:37.000000000 +0200
 @@ -283,6 +283,9 @@
  	/* Try the wheel first as the Z activator since it's tradition. */
  	wheel = hid_locate(desc, size, HID_USAGE2(HUP_GENERIC_DESKTOP,
  						  HUG_WHEEL),
 +			    hid_input, &sc->sc_loc_z, &flags) ||
 +		hid_locate(desc, size, HID_USAGE2(HUP_GENERIC_DESKTOP,
 +						  HUG_TWHEEL),
  			    hid_input, &sc->sc_loc_z, &flags);
  
  	if (wheel) {