Date: Wed, 30 Apr 2014 07:46:14 -0700 From: Thomas Skibo <ThomasSkibo@sbcglobal.net> To: Ian Lepore <ian@FreeBSD.org> Cc: freebsd-arm <freebsd-arm@FreeBSD.org> Subject: Re: sdhci_fdt ignores clock-frequency property in .dtb Message-ID: <53610CB6.6000003@sbcglobal.net> In-Reply-To: <1398816332.22079.49.camel@revolution.hippie.lan> References: <53601B1D.2090702@sbcglobal.net> <1398816332.22079.49.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
It looks like one other platform uses sdhci_fdt: exynos5250 (Chromebook). See exynos5250.dtsi. The "/* TODO: verify freq */" comment leads me to think they noticed that property wasn't working. I'm okay with max-frequency. I can generate a new patch. On 4/29/14, 5:05 PM, Ian Lepore wrote: > On Tue, 2014-04-29 at 14:35 -0700, Thomas Skibo wrote: >> Another Zynq bug-fix. One Zynq board out there needs to set this >> property or else the SD card gets clocked too fast. >> >> Thanks, >> > > The documented property for this is max-frequency rather than > clock-frequency. Is this a completely new property for us, or are you > just making the code honor what's in our existing dts files? Either way > we should use the documented name, I'm just wondering if we need to fix > dts files and give folks a heads-up about the change. > > -- Ian > > > -- -------- Thomas Skibo ThomasSkibo@sbcglobal.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53610CB6.6000003>