From nobody Fri Aug 25 16:20:27 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RXQCw12bRz4rT6f; Fri, 25 Aug 2023 16:20:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RXQCw0VwCz4qdV; Fri, 25 Aug 2023 16:20:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692980428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eSon4dvRrLViVIHaGQi+hjEcO8MY3fRDGM56oBznvx0=; b=l1MNNiKqJ2c/FaKV8nusApLYQj6DICqrI0A/M/yPrD9zfMJVeD+wE8M34A5+ueYz1S1zbl D9bostOo3fftklBD3qLX+SDDCazt9bMAv2IlL5J/OUoNBuDHetsEIOsL5Nu74PuJlKU+dO TPipcEdPEU+7CZn7HebKSHTK4DsdjY8uGapMQ3vixnPElSAc+UcsyoMQYwW7/alQ7uoZZV ohL4hhWfjP3Vd7AzGZTT/4qPWVk8NmH7ruR3OdD34ne6adbxf7B3WfSx2XtsJWqBGzq8Gv U0DedtN4F8ltT5DG3m+3mFIwArIYkzxtlCaNHdy/rf36+6aQlvoNseAgV1DodA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692980428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eSon4dvRrLViVIHaGQi+hjEcO8MY3fRDGM56oBznvx0=; b=qMqGIxQPosUJdDBT+3IdXJchbfrFhmqqys87C/ynHoG9S4i3o2HajHY58IcxM4WMe/Wa2z nbZz4+qtiPbvW0Oa0Z8Xwk7Ag6Z+5IoDrYMV7B5onXtVkdAaiUBlMJlKIbnWgs4NlI2nM+ XqBR58aBYWtv0z4t0E+eTBo75GDLYDdqaPhwiKxeVi8sXYAt/b0ogcv5ThSiyruybM587y ruMuI90QjQANCVL/OUoDfsVfmamcg/qD3IeEbHTuj84107P+pln2XH93t+m//WnGMczUfB 8TGlCt5AMyLadxffz3CHu06CAbTSEFoEu4FAxTlkQIX9D2E4G/vrBBT+cFRtEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692980428; a=rsa-sha256; cv=none; b=g3u4HZn6F4GJUewUdEUE6qSU9STnJSuD3GKhd0FkH2O3dez7Ipc2DuwmSlCM2QaCmS32tV knSFnlfb77QZoawlMlBRaNa/K3f3KJXQNF35T+mOTjHfa8UwV1T6l9nbmC5CTy567UHGXO tlTj4hifDC0xPH5/XR2pcoDNHztvggMscyqq4kuDsav082i7Cfl4PKIbxad+DmnJjo7a6m 5N+b2KRRzrWkqDSNVRUU/K7ZlfHGFd0A+xjG/+ffPt5bFrMI21A/B2pQ9q08KPC0GgImLj mxx6ujggKIa0/F0frpmlIeoNsJjZnm0o2AxKTmXixdUCxnRSDTZ2mb1wv7WpXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RXQCv6RgJz1F02; Fri, 25 Aug 2023 16:20:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 37PGKRgS076655; Fri, 25 Aug 2023 16:20:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 37PGKRiJ076652; Fri, 25 Aug 2023 16:20:27 GMT (envelope-from git) Date: Fri, 25 Aug 2023 16:20:27 GMT Message-Id: <202308251620.37PGKRiJ076652@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 2a6b7055a980 - main - nvme: Timeout expired transactions List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2a6b7055a980f7e7543dfdbda4aa0c356133b77d Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=2a6b7055a980f7e7543dfdbda4aa0c356133b77d commit 2a6b7055a980f7e7543dfdbda4aa0c356133b77d Author: Warner Losh AuthorDate: 2023-08-25 16:09:50 +0000 Commit: Warner Losh CommitDate: 2023-08-25 16:10:44 +0000 nvme: Timeout expired transactions When we went to having a shared timeout routine, failing the timed-out transaction code was inadvertantly dropped. Reinstate it. Fixes: 502dc84a8b670 Sponsored by: Netflix MFC After: 2 weeks Reviewed by: chuck, jhb Differential Revision: https://reviews.freebsd.org/D36921 --- sys/dev/nvme/nvme_qpair.c | 60 ++++++++++++++++++++++++++++++++++++----------- 1 file changed, 46 insertions(+), 14 deletions(-) diff --git a/sys/dev/nvme/nvme_qpair.c b/sys/dev/nvme/nvme_qpair.c index 45a999c17d89..0ad0b7cbe17f 100644 --- a/sys/dev/nvme/nvme_qpair.c +++ b/sys/dev/nvme/nvme_qpair.c @@ -944,6 +944,30 @@ nvme_io_qpair_destroy(struct nvme_qpair *qpair) nvme_qpair_destroy(qpair); } +static void +nvme_abort_complete(void *arg, const struct nvme_completion *status) +{ + struct nvme_tracker *tr = arg; + + /* + * If cdw0 == 1, the controller was not able to abort the command + * we requested. We still need to check the active tracker array, + * to cover race where I/O timed out at same time controller was + * completing the I/O. + */ + if (status->cdw0 == 1 && tr->qpair->act_tr[tr->cid] != NULL) { + /* + * An I/O has timed out, and the controller was unable to + * abort it for some reason. Construct a fake completion + * status, and then complete the I/O's tracker manually. + */ + nvme_printf(tr->qpair->ctrlr, + "abort command failed, aborting command manually\n"); + nvme_qpair_manual_complete_tracker(tr, + NVME_SCT_GENERIC, NVME_SC_ABORTED_BY_REQUEST, 0, ERROR_PRINT_ALL); + } +} + static void nvme_qpair_timeout(void *arg) { @@ -952,36 +976,44 @@ nvme_qpair_timeout(void *arg) struct nvme_tracker *tr; sbintime_t now; bool idle; + bool expired; uint32_t csts; uint8_t cfs; mtx_lock(&qpair->lock); idle = TAILQ_EMPTY(&qpair->outstanding_tr); + again: switch (qpair->recovery_state) { case RECOVERY_NONE: - if (idle) - break; + /* + * Check to see if we need to timeout any commands. If we do, then + * we also enter a recovery phase. + */ now = getsbinuptime(); - idle = true; + expired = false; TAILQ_FOREACH(tr, &qpair->outstanding_tr, tailq) { if (tr->deadline == SBT_MAX) continue; idle = false; if (now > tr->deadline) { - /* - * We're now passed our earliest deadline. We - * need to do expensive things to cope, but next - * time. Flag that and close the door to any - * further processing. - */ - qpair->recovery_state = RECOVERY_START; - nvme_printf(ctrlr, "RECOVERY_START %jd vs %jd\n", - (uintmax_t)now, (uintmax_t)tr->deadline); - break; + expired = true; + nvme_ctrlr_cmd_abort(ctrlr, tr->cid, qpair->id, + nvme_abort_complete, tr); } } - break; + if (!expired) + break; + + /* + * We're now passed our earliest deadline. We need to do + * expensive things to cope, but next time. Flag that + * and close the door to any further processing. + */ + qpair->recovery_state = RECOVERY_START; + nvme_printf(ctrlr, "RECOVERY_START %jd vs %jd\n", + (uintmax_t)now, (uintmax_t)tr->deadline); + /* FALLTHROUGH */ case RECOVERY_START: /* * Read csts to get value of cfs - controller fatal status.