Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Sep 2012 23:35:14 +0800 (CST)
From:      Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        gecko@FreeBSD.org
Subject:   ports/172164: [PATCH] security/nss: fix 'make install' when built with clang
Message-ID:  <3XTYjZ50J1z6Tl@sunpoet.net>
Resent-Message-ID: <201209291550.q8TFo7Qs022034@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         172164
>Category:       ports
>Synopsis:       [PATCH] security/nss: fix 'make install' when built with clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 29 15:50:06 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Sunpoet Po-Chuan Hsieh
>Release:        FreeBSD 9.1-PRERELEASE amd64
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD bonjour.sunpoet.net 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0: Sat Sep  8 01:52:48 CST
>Description:
- Fix 'make install' when built with clang

To build port with clang, I have following lines in /etc/make.conf:
CC=     /usr/bin/clang
CPP=    /usr/bin/clang-cpp
CXX=    /usr/bin/clang++

The installation failed when it tries to copy *.so.1 from ${BINS}, which should
be either ${DIST}/${OPSYS}${OSREL}_OPT.OBJ or ${DIST}/${OPSYS}${OSREL}_DBG.OBJ.
However, it's actually ${DIST}/${OPSYS}${OSREL}_clang_OPT.OBJ if DEBUG option is
off. This patch simply sets COMPILER_TAG empty to avoid such condition.

Port maintainer (gecko@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: SVN)
>How-To-Repeat:
>Fix:

--- nss-3.13.6.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 305013)
+++ Makefile	(working copy)
@@ -77,6 +77,8 @@
 		${FILESDIR}/nss-config.in >${WRKDIR}/nss-config
 	@${SED} -e 's|@PREFIX@|${PREFIX}|; s|@PORTVERSION@|${PORTVERSION}|' \
 		${FILESDIR}/nss.pc.in >${WRKDIR}/nss.pc
+	@${REINPLACE_CMD} -e 's|\(COMPILER_TAG = \).*|\1|' \
+		${WRKSRC}/../coreconf/ruleset.mk
 .for i in MAJOR MINOR PATCH
 	@${SED} -i.${i} -e 's|@${i}@|${_${i}}|' ${WRKDIR}/nss-config
 .endfor
--- nss-3.13.6.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3XTYjZ50J1z6Tl>