From owner-svn-src-all@freebsd.org Sat Apr 20 17:23:07 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A79181570F93 for ; Sat, 20 Apr 2019 17:23:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3FA126B9CD for ; Sat, 20 Apr 2019 17:23:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82e.google.com with SMTP id w5so8318164qtb.11 for ; Sat, 20 Apr 2019 10:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RkbNjvsXqcX+2/uBp8aX4R2YBGfjox9I/Og+lVXD4lM=; b=fWpdXHoLkkboTsd8Q7WTGvr0VPfr51bpV5jczFbM0WC6Ke5/hBH2XbD0tZiX9D7YCt 0PlCKG1cRm1ODRaJeiAHbdsazX+Ez2I0g3nVWcTnhYpggn582Ib9iW5KWy1i6dcTqzJ+ 8sRuL7T9f69p/+/lC/YdieSiuyR+mvywimbAfXgWBZW903h23kZxuoEJhe5N34dL3WSp zCq+WPEeQJrcqaOz8POrFF+ESMLVkaXNjV/aUN6B15pnKVwr9QSEVqckqSDD+EM7HFDL 1b8urznsp3Z1DrktniibBZMryk6afWnVeVCIKfG/eaNkz9XzL2MPiJIMr7Tycnz7W7Sz +2uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RkbNjvsXqcX+2/uBp8aX4R2YBGfjox9I/Og+lVXD4lM=; b=SfUj2EQUMz3HhelJU972z/aI9vuKYIz5+n6JA7Nl5jhWeo6cLIcjT2fhdFUQPoMVd/ YR8xtlp1fR7TBUGO2ZHVe3xCXI6lZhQdZhAFItW+zK2JTjncJalHoTDWjcvmJTn/tPxR MisukqxSf7elSA0tJTr5dI4o33ZJvaoo9N1gDJ66W1Px6Fjbnj1i6W9Y0l5aDxiCCH55 VDNWshakqSAxDrnCAhXGYVbaClqcOecckka4Z0ytSpzYX30kR6v6LCfPfEXdu1rpt+9V 8il7Tyw3Adf4Ovo2S+SvALuX+QrW8wfIHWlEuaouGBWkPBo0ZG1xAWoq2W2bEZ2aJXmj 26Vg== X-Gm-Message-State: APjAAAXkdO/W73fFmDSdlc2SFbJ8/6n3AAE4c3RcqNOZoY0Pxv84bG91 Wh0tZMGPN7761JNAZGOaT3OcVDq11gHnSKgQm3HKnw== X-Google-Smtp-Source: APXvYqxE7L+RFUhuptMvfiINdkWNV6SYYi4JS35NAkCh1ssbKdTxorab3hwu1fjz4Sp6wIImO7A1pJ5joAJ91feWrh0= X-Received: by 2002:ac8:1e0c:: with SMTP id n12mr2779062qtl.33.1555780986533; Sat, 20 Apr 2019 10:23:06 -0700 (PDT) MIME-Version: 1.0 References: <201904201251.x3KCp6it044898@repo.freebsd.org> <5bf4a702-7df8-5597-25b0-55baa71d1d4f@FreeBSD.org> <16BC7A31-39F3-4CFE-A6DA-5187FB154FA4@gmail.com> In-Reply-To: <16BC7A31-39F3-4CFE-A6DA-5187FB154FA4@gmail.com> From: Warner Losh Date: Sat, 20 Apr 2019 11:22:54 -0600 Message-ID: Subject: Re: svn commit: r346441 - in head/sys/modules: em fusefs iavf To: Garrett Cooper Cc: John Baldwin , Justin Hibbits , Alan Somers , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 3FA126B9CD X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.940,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Apr 2019 17:23:08 -0000 On Sat, Apr 20, 2019, 10:46 AM Enji Cooper wrote: > > > > On Apr 20, 2019, at 9:44 AM, John Baldwin wrote: > > > > On 4/20/19 6:23 AM, Justin Hibbits wrote: > >> On Sat, Apr 20, 2019, 08:21 Alan Somers wrote: > >> > >>> On Sat, Apr 20, 2019 at 6:58 AM Justin Hibbits > >>> wrote: > >>>> > >>>> > >>>> > >>>> On Sat, Apr 20, 2019, 07:51 Alan Somers wrote: > >>>>> > >>>>> Author: asomers > >>>>> Date: Sat Apr 20 12:51:05 2019 > >>>>> New Revision: 346441 > >>>>> URL: https://svnweb.freebsd.org/changeset/base/346441 > >>>>> > >>>>> Log: > >>>>> Use symlinks for kernel modules rather than hardlinks > >>>>> > >>>>> When aliasing a kernel module to a different name (ie if_igb for > >>> if_em), > >>>>> it's better to use symlinks than hard links. kldxref will omit > >>> entries for > >>>>> the links, ensuring that the loaded module has the correct name. > >>>>> > >>>>> > >>>> > >>>> > >>>> Thanks! This should fix installkernel on my POWER9. > >>>> > >>>> - Justin > >>> > >>> What's the problem with your POWER9? Is that one of those msdosfs > >>> /boot systems? If so, I don't think this will fix it. msdosfs > >>> doesn't support either symlinks or hardlinks. Or is there some other > >>> problem? > >>> -Alan > >>> > >> > >> Yes it is. Well that's a bummer then. I thought we faked symlinks on > >> msdosfs, but on second thought not sure how well would do that. > > > > You could just use cp instead of a link? > > *eyes `install -l`*: > > -l linkflags > Instead of copying the file make a link to the source. The > type > of the link is determined by the linkflags argument. Valid > linkflags are: a (absolute), r (relative), h (hard), s > (symbolic), m (mixed). Absolute and relative have effect only > for symbolic links. Mixed links are hard links for files on > the > same filesystem, symbolic otherwise. > None of those are helpful. Better to just not do the link for a system we don't the compat links for.... Warner Cheers, > -Enji > >