From owner-freebsd-current Thu May 25 14:35:51 2000 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 3886137B519 for ; Thu, 25 May 2000 14:35:47 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.3) with ESMTP id XAA06981; Thu, 25 May 2000 23:33:31 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Bruce Evans Cc: Garrett Wollman , Jake Burkholder , Chuck Robey , FreeBSD-current Subject: Re: HEADS UP Re: cvs commit: src/crypto/openssh/pam_ssh pam_ssh.c src/gnu/usr.bin/binutils/gdb freebsd-uthread.c src/include mpool.h src/lib/libc/net name6.c src/lib/libc_r/uthread pthread_private.h uthread_file.c src/lib/libncp ncpl_rcfile.c src/lib/libstand if_ether.h ... In-reply-to: Your message of "Thu, 25 May 2000 01:20:05 +1000." Date: Thu, 25 May 2000 23:33:31 +0200 Message-ID: <6979.959290411@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message , Bruce Evans writes: >On Wed, 24 May 2000, Garrett Wollman wrote: > >> < said: >> >> > I've just built a fresh world here; if you use the cvs-crypto from >> > internat, it may be broken. I submitted a patch to Mark Murray which >> > should fix it, here it is again just in case: >> >> I still think (and am going on record) that this is a REALLY, REALLY >> BAD idea. > >Especially since most of the queue macros require the type to be a struct >to work. E.g.: > >#define SLIST_REMOVE(head, elm, type, field) do { \ > ^^^^ a supposedly general type > if (SLIST_FIRST((head)) == (elm)) { \ > SLIST_REMOVE_HEAD((head), field); \ > } \ > else { \ > type *curelm = SLIST_FIRST((head)); \ > while (SLIST_NEXT(curelm, field) != (elm)) \ > ^^^^^^^^^^^^^^^^^^^^^^^^^ > >I objected to a recent commit hiding the fact that this is >"(elm)->field.sle_next". Anyway, curelm must be a pointer to a struct. >Not just any struct; the struct must contain a "field" declared using >SLIST_ENTRY(). It could be an union or class as well... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD coreteam member | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message