From owner-freebsd-fs@FreeBSD.ORG  Fri Aug 31 23:06:03 2012
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 12B351065673;
	Fri, 31 Aug 2012 23:06:03 +0000 (UTC)
	(envelope-from trent@snakebite.org)
Received: from exchange.liveoffice.com (exchla3.liveoffice.com [64.70.67.188])
	by mx1.freebsd.org (Postfix) with ESMTP id E8A0B8FC0C;
	Fri, 31 Aug 2012 23:06:02 +0000 (UTC)
Received: from EXHUB03.exchhosting.com (192.168.11.104) by
	exhub08.exchhosting.com (192.168.11.106) with Microsoft SMTP Server
	(TLS) id 8.3.213.0; Fri, 31 Aug 2012 16:05:56 -0700
Received: from localhost (35.8.247.10) by exchange.liveoffice.com
	(192.168.11.104) with Microsoft SMTP Server id 8.3.213.0;
	Fri, 31 Aug 2012 16:05:55 -0700
Date: Fri, 31 Aug 2012 19:05:53 -0400
From: Trent Nelson <trent@snakebite.org>
To: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <20120831230553.GC59852@snakebite.org>
References: <20120824011517.GJ42732@snakebite.org>
	<503CD4F1.6060001@FreeBSD.org> <503CDD4E.6050902@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <503CDD4E.6050902@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: "freebsd-fs@FreeBSD.org" <freebsd-fs@FreeBSD.org>
Subject: Re: chmod -h 000x against symlink has bizarre results on ZFS
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Aug 2012 23:06:03 -0000

On Tue, Aug 28, 2012 at 08:01:34AM -0700, Andriy Gapon wrote:
> on 28/08/2012 17:25 Andriy Gapon said the following:
> Will you be able to test the following patch?
> Preferably on a temporary test pool - I don't want to risk your data.
> 
> diff --git a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> index 69374fb..7f61517 100644
> --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> @@ -1695,6 +1695,7 @@ sa_modify_attrs(sa_handle_t *hdl, sa_attr_type_t newattr,
>  				ASSERT(action == SA_REPLACE);
>  				SA_ADD_BULK_ATTR(attr_desc, j, attr,
>  				    locator, datastart, buflen);
> +				length_idx++;
>  			} else {
>  				length = SA_REGISTERED_LEN(sa, attr);
>  				if (length == 0) {
> 

    That looks like it did the trick.  Nice one :-)

    What's the protocol for ZFS bugfixes?  I'm happy to do the leg work
    (submitting PRs to other teams etc).

> Andriy Gapon

        Trent.