From owner-freebsd-bugs@FreeBSD.ORG Sun Feb 16 17:00:03 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0979AFD3 for ; Sun, 16 Feb 2014 17:00:03 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E9A631C80 for ; Sun, 16 Feb 2014 17:00:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1GH02FC045426 for ; Sun, 16 Feb 2014 17:00:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1GH02fL045425; Sun, 16 Feb 2014 17:00:02 GMT (envelope-from gnats) Date: Sun, 16 Feb 2014 17:00:02 GMT Message-Id: <201402161700.s1GH02fL045425@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Andriy Gapon Subject: Re: kern/184092: zfs zvol devices are not appearing till after reimport of pool X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Andriy Gapon List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Feb 2014 17:00:03 -0000 The following reply was made to PR kern/184092; it has been noted by GNATS. From: Andriy Gapon To: d@delphij.net, Christopher Harrison , freebsd-gnats-submit@FreeBSD.org Cc: Subject: Re: kern/184092: zfs zvol devices are not appearing till after reimport of pool Date: Sun, 16 Feb 2014 18:52:20 +0200 on 19/11/2013 20:50 Xin Li said the following: > I think Andriy (cc'ed) have fixed a similar issue. A quick glance at the > code suggests maybe we can use something like this: I am not sure if I have ever fixed this -- if you have a reference then please share with :-) But the change looks good to me and I also think that Steve Hartland proposed this change as well. Thanks! And sorry for the delay with my reply. > Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c > =================================================================== --- > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c (revision > 258350) +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c > (working copy) @@ -3298,6 +3298,10 @@ zfs_ioc_clone(const char *fsname, > nvlist_t *innvl, if (error != 0) (void) dsl_destroy_head(fsname); } +#ifdef > __FreeBSD__ + if (error == 0) + > zvol_create_minors(fsname); +#endif return (error); } > > Can you confirm if this helps? > > (I think we should use a better way to trigger zvol_create_minor, maybe via > a devfs lookup hook?) > > Cheers, > -- Andriy Gapon