From owner-freebsd-current@FreeBSD.ORG  Tue Oct 11 18:18:01 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4AA8C16A41F
	for <current@freebsd.org>; Tue, 11 Oct 2005 18:18:01 +0000 (GMT)
	(envelope-from maksim.yevmenkin@savvis.net)
Received: from ismybrain.com (ismybrain.com [64.246.42.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DA2DB43D45
	for <current@freebsd.org>; Tue, 11 Oct 2005 18:18:00 +0000 (GMT)
	(envelope-from maksim.yevmenkin@savvis.net)
Received: from [10.254.186.111] (localhost.localdomain [127.0.0.1])
	by ismybrain.com (8.11.6/8.11.6) with ESMTP id j9BIHxJ05570
	for <current@freebsd.org>; Tue, 11 Oct 2005 14:17:59 -0400
Message-ID: <434C01D2.4040003@savvis.net>
Date: Tue, 11 Oct 2005 11:17:54 -0700
From: Maksim Yevmenkin <maksim.yevmenkin@savvis.net>
User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050404)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: current@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: buildkernel is broken in if_ndis
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2005 18:18:01 -0000

dear hackers,

make buildworld is broken for me. since NDIS_LOCK(sc) does not uses 
sc->ndis_mtx anymore, shouldn't the following patch be put in place?

max

p.s. i could not find KeIsInitializedSpinLock function in subr_ndis.c. 
quick look at msdn did not reveal it either


--- if_ndis.c.orig      Tue Oct 11 11:11:52 2005
+++ if_ndis.c   Tue Oct 11 11:11:31 2005
@@ -917,8 +917,6 @@
         driver_object           *drv;

         sc = device_get_softc(dev);
-       KASSERT(mtx_initialized(&sc->ndis_mtx),
-           ("ndis mutex not initialized"));
         NDIS_LOCK(sc);
         ifp = sc->ifp;
         ifp->if_flags &= ~IFF_UP;