From owner-svn-src-all@freebsd.org Mon Oct 30 02:30:32 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1FA2AE52167 for ; Mon, 30 Oct 2017 02:30:32 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) by mx1.freebsd.org (Postfix) with ESMTP id C14176FA31 for ; Mon, 30 Oct 2017 02:30:31 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) by alto.onthenet.com.au (Postfix) with ESMTPS id D681F20ADC0D for ; Mon, 30 Oct 2017 12:30:27 +1000 (AEST) Received: from localhost (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id CD0A3281E00 for ; Mon, 30 Oct 2017 12:30:27 +1000 (AEST) X-Amavis-Modified: Mail body modified (using disclaimer) - iredmail.onthenet.com.au Received: from iredmail.onthenet.com.au ([127.0.0.1]) by localhost (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id FU6bDfyaokkY for ; Mon, 30 Oct 2017 12:30:27 +1000 (AEST) Received: from Peters-MacBook-Pro-2.local (c-67-180-92-13.hsd1.ca.comcast.net [67.180.92.13]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 9B1862808EE; Mon, 30 Oct 2017 12:30:25 +1000 (AEST) Subject: Re: svn commit: r325108 - head/sys/amd64/vmm/io To: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201710292050.v9TKo3j5058456@repo.freebsd.org> <1509310495.21609.60.camel@freebsd.org> <3b1ffc68-def3-04f6-2a1e-af44d6f3b4a5@freebsd.org> <1509330161.21609.86.camel@freebsd.org> From: Peter Grehan Message-ID: <66f496cb-c2c4-3044-333e-84540bdd64c2@freebsd.org> Date: Sun, 29 Oct 2017 19:30:25 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509330161.21609.86.camel@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-CMAE-Score: 0 X-CMAE-Analysis: v=2.2 cv=XKlAcUpE c=1 sm=1 tr=0 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=5eVCmCvhg37cu/pjidAGzw==:17 a=IkcTkHD0fZMA:10 a=02M-m0pO-4AA:10 a=U6saa0QbdT0wPyApqsAA:9 a=QEXdDO2ut3YA:10 wl=host:3 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 02:30:32 -0000 Hi Ian, > In fact I did check maintainers, and I just now checked it again, and > seeing nothing on-point, wrote a really snarky reply. >=20 > Luckily, before hitting send I realized you wouldn't have said anything > unless there was an entry in there, so I checked like 4 more times > before I noticed the line that begins vmm(4). =C2=A0I had been looking = for a > line that began with sys/amd64. >=20 > So... sorry about that. =C2=A0Should I revert it and open a review? No, it's fine. It's a good idea in general for code in that area since=20 there are often unintended side-effects with guest behaviour, and=20 putting up a review can at least flush out folk who might have more=20 insight into that. I'll update the maintainer's file to include the directory. > Longer-term, I was hoping to find some time over the next few weeks to > further explore the roundoff errors in the timers and attempt a better > fix, and I was definitely intending to put that up for review > (especially because it involves math, and I'm always better off asking > for help with that). I know Rod Grimes is going to be doing some testing this week with=20 clock drift in guests, and I'll do some dtrace work on HPET usage with=20 non-FreeBSD guests. Timer accuracy has long been an issue with bhyve so any help in this=20 area is much appreciated. later, Peter.