From owner-freebsd-mobile Sun Feb 14 13:12:06 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA09792 for freebsd-mobile-outgoing; Sun, 14 Feb 1999 13:12:06 -0800 (PST) (envelope-from owner-freebsd-mobile@FreeBSD.ORG) Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA09752 for ; Sun, 14 Feb 1999 13:11:59 -0800 (PST) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id OAA22260; Sun, 14 Feb 1999 14:11:27 -0700 (MST) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id OAA22337; Sun, 14 Feb 1999 14:11:24 -0700 Date: Sun, 14 Feb 1999 14:11:24 -0700 Message-Id: <199902142111.OAA22337@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Warner Losh Cc: Mitsuru IWASAKI , Valentin Shopov , mobile@FreeBSD.ORG, Nate Williams Subject: Re: apm & current In-Reply-To: <199902142102.OAA32088@harmony.village.org> References: <199902141646.BAA21353@tasogare.imasy.or.jp> <19990213153958.2977.rocketmail@send1e.yahoomail.com> <199902142102.OAA32088@harmony.village.org> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > : So, now I'm going to commit version checking code just before > : calling apm_bios_call() in /sys/i386/apm/apm.c into PAO3 CVS repository. > > These patches look basically good. I'll integrate them when I have a > chance. The only issue I have is the plethora of 'options'. There's got to be a better way of configuring the apm device, and adding more options is *NOT* the way to do it. Also, last I looked (quite a while ago, just before APM 1.2 was standardized) the PAO code did not follow the APM specifications when probing. Some of this code was merged into the tree by PHK in Rev 1.55, but I quit arguing about it. This might explain why APM 1.2 commands cause the system to fail, although I'm not sure how they are implemented in the code. I think the patch could make this checking much easier by adding a variable to softc stating the version. That way the check is very simple instead of the complicated way it's done now. In other words, I don't think the patches as sent are very clean, although the functionality in them may be correct. Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message