From owner-p4-projects@FreeBSD.ORG Fri Jan 5 00:26:33 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 050A716A55F; Fri, 5 Jan 2007 00:26:32 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BAEA716A501 for ; Fri, 5 Jan 2007 00:26:32 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id A937513C465 for ; Fri, 5 Jan 2007 00:26:32 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l050QWMw065992 for ; Fri, 5 Jan 2007 00:26:32 GMT (envelope-from mjacob@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l050QWH4065988 for perforce@freebsd.org; Fri, 5 Jan 2007 00:26:32 GMT (envelope-from mjacob@freebsd.org) Date: Fri, 5 Jan 2007 00:26:32 GMT Message-Id: <200701050026.l050QWH4065988@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to mjacob@freebsd.org using -f From: Matt Jacob To: Perforce Change Reviews Cc: Subject: PERFORCE change 112506 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2007 00:26:33 -0000 http://perforce.freebsd.org/chv.cgi?CH=112506 Change 112506 by mjacob@mjexp on 2007/01/05 00:26:10 Add 'clear' command. Affected files ... .. //depot/projects/mjexp/sbin/geom/class/multipath/geom_multipath.c#4 edit Differences ... ==== //depot/projects/mjexp/sbin/geom/class/multipath/geom_multipath.c#4 (text+ko) ==== @@ -47,11 +47,16 @@ static void mp_main(struct gctl_req *, unsigned int); static void mp_label(struct gctl_req *); +static void mp_clear(struct gctl_req *); struct g_command class_commands[] = { { "label", G_FLAG_VERBOSE | G_FLAG_LOADKLD, mp_main, G_NULL_OPTS, - "[-v] name prov prov" + "[-v] name prov ..." + }, + { + "clear", G_FLAG_VERBOSE, mp_main, G_NULL_OPTS, + "[-v] prov ..." }, { "destroy", G_FLAG_VERBOSE, NULL, G_NULL_OPTS, @@ -72,6 +77,8 @@ } if (strcmp(name, "label") == 0) { mp_label(req); + } if (strcmp(name, "clear") == 0) { + mp_clear(req); } else { gctl_error(req, "Unknown command: %s.", name); } @@ -90,7 +97,7 @@ int error, i, nargs; nargs = gctl_get_int(req, "nargs"); - if (nargs != 3) { + if (nargs < 2) { gctl_error(req, "wrong number of arguments."); return; } @@ -201,3 +208,28 @@ } } } + +static void +mp_clear(struct gctl_req *req) +{ + const char *name; + int error, i, nargs; + + nargs = gctl_get_int(req, "nargs"); + if (nargs < 1) { + gctl_error(req, "Too few arguments."); + return; + } + + for (i = 0; i < nargs; i++) { + name = gctl_get_ascii(req, "arg%d", i); + error = g_metadata_clear(name, G_MULTIPATH_MAGIC); + if (error != 0) { + fprintf(stderr, "Can't clear metadata on %s: %s.\n", + name, strerror(error)); + gctl_error(req, "Not fully done."); + continue; + } + } +} +