From nobody Sat Oct 14 01:09:01 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S6ldB520tz4x49K; Sat, 14 Oct 2023 01:09:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S6ldB0gcZz3Y96; Sat, 14 Oct 2023 01:09:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697245742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xby+U2TzZ4S5HizUWUHgrlCZBbOWvde/dJropzJpPmg=; b=iyfpHzGhwRBkLImynRg5elGo86664nKprgVxl9gDNaIrRV5gCdPAJ8u1cnwp3DdiOrKG+v AJ5LAGmUAUFnRXgG038NakRgCJwq+jW1RqrLmuobD6EDxz6khsu36OF35wOrDF9hknkkFR xBSEMV6b4i2DwPeVbsBfmvFNhQB1zoBVu5Rb79ynXNIiOjche4TGT24PB5R4QCIOCxt9+E spiW0EJ2k/2ec+xDLhutsVHLr8fDny1Xe/3JT1ictRyq34aY3Iv8zczQG6STpibGFpr6ef 95s3GtwRqLHh29IlEYrSNJNV0I2v3gf1Np0xAvY6p6FGj5v/Q87c3Ozm+tGweg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697245742; a=rsa-sha256; cv=none; b=PiTd5Vx0hqIoIZF1HS3REp/5fj4Y8+AA6NmJ4Mc5Fcr/J0D65kwk2DgQL4ZUDxISrs5pyX q0WwVhIt5RxTx1zm/1jwm9jEQ3zbImeyg1B43fvcO2WG5WUFzelBa05eZWZ52YAL0Jq+Cf kYYxjRaNNQdgMOu7VukgfO6Iw6ty71+QjJp0EOTGrH/OLAHgpMZE9lwy7dBgvfwLUSIWKe y30rWhBVS6gYGcBollLapLxHEyw+YgjVi9uB0kDDLQAoj4w5fxPFXgYg8VhFaJ2K/Jn9So Pp+6l6oMAnKly9x1s9UBhNryKyqbd0v0rDqRKHh0EU6CPiz2MuJY32nT9G/alQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697245742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xby+U2TzZ4S5HizUWUHgrlCZBbOWvde/dJropzJpPmg=; b=vCqzNxmwbw2h0bt/oDSTt7Qt7fNdILJWzYMsIvb0+/52GTaXsF89wPdOFPaLWtAP/0+v3W qmm/PoIPoLMsQijqLaJesObDFHIAWhd0NiPB3W9ukK2qALeReYUMT6uVmWuD8R9EO6uHVd vgsyQ5bfvqRhbshOp9E0jncnjPXsiOUjtce9YgJtUL63zH9E3Gg4ID/2dwXXfLHFQ9Mxbq DSD855tGVROuo5T5wKko9CwSQThP6rPzNE25i12Gk01sLFnxt/IHA+IPbrWcrd04rMs+Mu Ceg7PWSxUp9AWqqMlxQELtwn7ucmHzUvt4FKlvwgo22qRklplG0D/nlntNOYFQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S6ld96vChz19Ht; Sat, 14 Oct 2023 01:09:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39E191fu052818; Sat, 14 Oct 2023 01:09:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39E191Se052815; Sat, 14 Oct 2023 01:09:01 GMT (envelope-from git) Date: Sat, 14 Oct 2023 01:09:01 GMT Message-Id: <202310140109.39E191Se052815@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: a0c5d373435c - releng/14.0 - vfs cache: Drop known argument of internal cache_recalc_neg_min() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: a0c5d373435c88b4076485251b13dcae279f1655 Auto-Submitted: auto-generated The branch releng/14.0 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=a0c5d373435c88b4076485251b13dcae279f1655 commit a0c5d373435c88b4076485251b13dcae279f1655 Author: Olivier Certner AuthorDate: 2023-09-22 21:25:41 +0000 Commit: Mateusz Guzik CommitDate: 2023-10-14 01:08:31 +0000 vfs cache: Drop known argument of internal cache_recalc_neg_min() 'ncnegminpct' is to be passed always, so just drop the unneeded parameter. Sponsored by: The FreeBSD Foundation Reviewed by: mjg Differential Revision: https://reviews.freebsd.org/D41763 (cherry picked from commit 02ef039c284b8a7b1ea40f5f9a851a3cb6af5b31) (cherry picked from commit fc424de7e192bb33793ba1f7ed0c75b961809bf4) Approved by: re (gjb) --- sys/kern/vfs_cache.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index bd9eac69bfcb..115d0bdd3993 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -985,10 +985,10 @@ SYSCTL_PROC(_vfs_cache, OID_AUTO, nchstats, CTLTYPE_OPAQUE | CTLFLAG_RD | "VFS cache effectiveness statistics"); static void -cache_recalc_neg_min(u_int val) +cache_recalc_neg_min(void) { - neg_min = (ncsize * val) / 100; + neg_min = (ncsize * ncnegminpct) / 100; } static int @@ -1007,7 +1007,7 @@ sysctl_negminpct(SYSCTL_HANDLER_ARGS) if (val < 0 || val > 99) return (EINVAL); ncnegminpct = val; - cache_recalc_neg_min(val); + cache_recalc_neg_min(); return (0); } @@ -2665,7 +2665,7 @@ nchinit(void *dummy __unused) VFS_SMR_ZONE_SET(cache_zone_large_ts); ncsize = desiredvnodes * ncsizefactor; - cache_recalc_neg_min(ncnegminpct); + cache_recalc_neg_min(); nchashtbl = nchinittbl(desiredvnodes * 2, &nchash); ncbuckethash = cache_roundup_2(mp_ncpus * mp_ncpus) - 1; if (ncbuckethash < 7) /* arbitrarily chosen to avoid having one lock */ @@ -2809,7 +2809,7 @@ cache_changesize(u_long newmaxvnodes) } } ncsize = newncsize; - cache_recalc_neg_min(ncnegminpct); + cache_recalc_neg_min(); cache_changesize_set_new(new_nchashtbl, new_nchash); cache_unlock_all_buckets(); cache_unlock_all_vnodes();