From owner-svn-src-head@freebsd.org  Sun Jun 26 16:09:12 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18F0EB81E2B;
 Sun, 26 Jun 2016 16:09:12 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7F48323ED;
 Sun, 26 Jun 2016 16:09:11 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u5QG96pF036420
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Sun, 26 Jun 2016 19:09:06 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u5QG96pF036420
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id u5QG96Oi036419;
 Sun, 26 Jun 2016 19:09:06 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 26 Jun 2016 19:09:06 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Benjamin Kaduk <bjkfbsd@gmail.com>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject: Re: svn commit: r302210 - head/sys/fs/nfsclient
Message-ID: <20160626160906.GC38613@kib.kiev.ua>
References: <201606261418.u5QEITxu002962@repo.freebsd.org>
 <CAJ5_RoB+z6+HBUd1Hzp38o1QP3uo8UNNwT319af+5dVGw8NSaw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJ5_RoB+z6+HBUd1Hzp38o1QP3uo8UNNwT319af+5dVGw8NSaw@mail.gmail.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Jun 2016 16:09:12 -0000

On Sun, Jun 26, 2016 at 10:54:44AM -0500, Benjamin Kaduk wrote:
> On Sun, Jun 26, 2016 at 9:18 AM, Konstantin Belousov <kib@freebsd.org>
> wrote:
> 
> > Author: kib
> > Date: Sun Jun 26 14:18:28 2016
> > New Revision: 302210
> > URL: https://svnweb.freebsd.org/changeset/base/302210
> >
> > Log:
> >   Clean other flags in ncl_inactive, only.  Add comment explaining why
> > other
> >   flags should be unset.
> >
> [...]
> 
> > +
> > +       /*
> > +        * NMODIFIED means that there might be dirty/stale buffers
> > +        * associated with the NFS vnode.  None of the other flags are
> > +        * meaningful after the vnode is unused.
> > +        */
> > +       np->n_flag &= NMODIFIED;
> >
> 
> Maybe I am confused, but the commit message reads like this should be '=',
> not '&='.

The line clears all flags except NMODIFIED, and lefts the NMODIFIED flag
intact (it could have been not set there, after all).