From owner-freebsd-hackers Wed Apr 24 15:21:24 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id PAA03605 for hackers-outgoing; Wed, 24 Apr 1996 15:21:24 -0700 (PDT) Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.211]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id PAA03599 for ; Wed, 24 Apr 1996 15:21:22 -0700 (PDT) Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id PAA23109; Wed, 24 Apr 1996 15:14:31 -0700 From: Terry Lambert Message-Id: <199604242214.PAA23109@phaeton.artisoft.com> Subject: Re: GNU binutils port To: msmith@atrad.adelaide.edu.au (Michael Smith) Date: Wed, 24 Apr 1996 15:14:31 -0700 (MST) Cc: jmacd@CS.Berkeley.EDU, bde@zeta.org.au, freebsd-hackers@FreeBSD.org In-Reply-To: <199604241157.VAA19097@genesis.atrad.adelaide.edu.au> from "Michael Smith" at Apr 24, 96 09:27:21 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-hackers@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > > Oh dear.... I can't beleive you're saying this, "They are only warnings". > > > > To me, it has, "My code sucks and I don't care." written all over > > it if you don't fix things so that they compile with no warnings > > and -Wall. Perhaps kernel code is a bit different, but with 4700 > > warnings, I'd be little scared. > > gcc -Wall is _pedantic_. Consider how many of the above are > "Consider parentheses around assignment used as truth value", or > "Integer used as pointer without a cast" (for use of '0' as a [legitimate] > substitute for NULL. > > A pile more would be historic warts where unions were avoided and pointers > to structures were passed around in a known context. Not to mention: if( ret = (x>>8)) "WARNING: ASSIGNMENT IN IF STATEMENT! I AM UNUTTERABLY ANAL!" Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.