From owner-svn-src-head@freebsd.org  Sun Nov  5 18:56:29 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BAE73E4E2CD
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Sun,  5 Nov 2017 18:56:29 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org
 [52.58.109.202])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 54AA3657DD
 for <svn-src-head@freebsd.org>; Sun,  5 Nov 2017 18:56:28 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: ff8e21eb-c25a-11e7-b805-f37e907b5733
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 73.78.92.27
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [73.78.92.27])
 by outbound1.eu.mailhop.org (Halon) with ESMTPSA
 id ff8e21eb-c25a-11e7-b805-f37e907b5733;
 Sun, 05 Nov 2017 18:56:16 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id vA5IuEhq010763;
 Sun, 5 Nov 2017 11:56:14 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <1509908174.99235.60.camel@freebsd.org>
Subject: Re: svn commit: r325368 - head/sys/kern
From: Ian Lepore <ian@freebsd.org>
To: Ed Maste <emaste@freebsd.org>, Bryan Drewery <bdrewery@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Date: Sun, 05 Nov 2017 11:56:14 -0700
In-Reply-To: <CAPyFy2D0c6GQvrfE9CAx99Pj+F5QU_y+B6rpOY3BCPSFNDA5mA@mail.gmail.com>
References: <201711031921.vA3JLakQ010001@repo.freebsd.org>
 <15dc8575-c699-1101-c846-b4fbdef3d1d1@FreeBSD.org>
 <CAPyFy2D0c6GQvrfE9CAx99Pj+F5QU_y+B6rpOY3BCPSFNDA5mA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Nov 2017 18:56:29 -0000

On Fri, 2017-11-03 at 17:22 -0400, Ed Maste wrote:
> "On 3 November 2017 at 16:42, Bryan Drewery <bdrewery@freebsd.org>
> wrote:
> > 
> > 
> > > 
> > >   Differential Revision:      D12929
> > Apparently this format closes the review now? I thought we needed a
> > full
> > URL?
> Interesting, Phabricator reports "We found a "Differential Revision"
> field with value "12929" in the commit message, and the domain on the
> URI matches this install, so we linked this commit to D12929."  It
> looks like Phabricator was changed to accept only the D##### tag, but
> not the "Explain why" text.
> 

I like having the full URL, and would like that to remain the standard.
 It's very useful when you're perusing svn logs and you can just click
on the url to get to the phab material cited in the commit.

If people want the convenience of typing the shorter info, could we
make the svn commit hooks expand it to an url?

-- Ian