From owner-cvs-src@FreeBSD.ORG Mon Jan 26 12:08:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 183EB16A4CE; Mon, 26 Jan 2004 12:08:08 -0800 (PST) Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B29A43D1F; Mon, 26 Jan 2004 12:08:06 -0800 (PST) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id i0QK85578730; Mon, 26 Jan 2004 15:08:05 -0500 (EST) (envelope-from jroberson@chesapeake.net) Date: Mon, 26 Jan 2004 15:08:05 -0500 (EST) From: Jeff Roberson To: John Baldwin In-Reply-To: <200401261026.56106.jhb@FreeBSD.org> Message-ID: <20040126150636.E36463-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: Jeff Roberson cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 local_apic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2004 20:08:08 -0000 On Mon, 26 Jan 2004, John Baldwin wrote: > On Sunday 25 January 2004 12:03 am, Jeff Roberson wrote: > > jeff 2004/01/24 21:03:14 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/i386/i386 local_apic.c > > Log: > > - Don't define DETECT_DEADLOCK. I don't know that this code has > > detected a deadlock in several years. Furthermore, the IPI code is > > currently protected by a seperate spinlock. This only served to make IPIs > > twice as expensive as they had to be which severely slowed down the IPI > > heavy ULE scheduler. > > What spinlock? Er, based on earlier conversations with you I was under the assumption that there was a lock around all of the ipi sender code. I must have this confused with something else. > > > grep mtx local_apic.c | wc -l > 0 > > Some users of the ipi API use a spinlock themselves, but not all, and there > certainly isn't a global ipi spin lock. According to witness, only sparc64 > has an ipi spin lock. It might still be a good idea to turn this off or > perhaps at least half of it. We will lose ipi's on non-XAPIC systems if you > don't wait for the delivery status to clear before sending an IPI. Have you > tested this on Pentium II's or earlier? My original patch did still poll before transmit. I'll correct this. Thanks, Jeff > > -- > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve" = http://www.FreeBSD.org >