From owner-svn-ports-all@freebsd.org Sat Mar 19 20:39:53 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCF35AD57B7 for ; Sat, 19 Mar 2016 20:39:53 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: from vfemail.net (onethreetwo.vfemail.net [199.16.11.132]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 64E2994E for ; Sat, 19 Mar 2016 20:39:52 +0000 (UTC) (envelope-from jbeich@vfemail.net) Received: (qmail 81001 invoked by uid 89); 19 Mar 2016 20:39:51 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 19 Mar 2016 20:39:49 -0000 Received: (qmail 55191 invoked by uid 89); 19 Mar 2016 18:23:12 -0000 Received: by simscan 1.3.1 ppid: 55183, pid: 55187, t: 0.0041s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 19 Mar 2016 18:23:12 -0000 Received: (qmail 15071 invoked by uid 89); 19 Mar 2016 18:23:12 -0000 Received: by simscan 1.4.0 ppid: 15045, pid: 15066, t: 0.7033s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by mail.vfemail.net with ESMTPA; 19 Mar 2016 18:23:11 -0000 From: Jan Beich To: Thomas Zander Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r411417 - in head/multimedia: . libdcadec References: <201603191745.u2JHjOqA065172@repo.freebsd.org> Date: Sat, 19 Mar 2016 19:22:57 +0100 In-Reply-To: <201603191745.u2JHjOqA065172@repo.freebsd.org> (Thomas Zander's message of "Sat, 19 Mar 2016 17:45:24 +0000 (UTC)") Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Mar 2016 20:39:53 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable (Simple ports tend to have more style issues, paradoxically) Thomas Zander writes: > +GH_TAGNAME=3D v${PORTVERSION} Convert to DISTVERSIONPREFIX and re-run |make makesum|. It should remove version duplication from distinfo. > +NO_CONFIGURE=3D yes Why? bsd.port.mk explicitly says there's no such variable. > +USES=3D pkgconfig gmake Maybe sort. > +LDFLAGS+=3D -lm Maybe use LIBS to undo MAKE_ENV damage. > + -e 's;$$(LIBDIR)/pkgconfig;$$(PREFIX)/libdata/pkgconfig;' \ Maybe convert to USES=3D ... pathfix PATHFIX_MAKEFILEIN=3D Makefile > ${REINPLACE_CMD} -e 's;INCLUDEDIR;MYINCLUDEDIR;g' \ > -e 's;LIBDIR;MYLIBDIR;g' \ > ${WRKSRC}/dcadec.pc.in \ > ${WRKSRC}/Makefile MAKE_ARGS would be shorter. Index: multimedia/libdcadec/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- multimedia/libdcadec/Makefile (revision 411417) +++ multimedia/libdcadec/Makefile (working copy) @@ -2,6 +2,7 @@ =20 PORTNAME=3D libdcadec PORTVERSION=3D 0.2.0 +DISTVERSIONPREFIX=3D v CATEGORIES=3D multimedia =20 MAINTAINER=3D mickael.maillot@gmail.com @@ -12,22 +13,15 @@ LICENSE=3D LGPL21 USE_GITHUB=3D yes GH_ACCOUNT=3D foo86 GH_PROJECT=3D dcadec =2DGH_TAGNAME=3D v${PORTVERSION} =20 =2DNO_CONFIGURE=3D yes =2DUSES=3D pkgconfig gmake =2DLDFLAGS+=3D -lm +USES=3D gmake pathfix pkgconfig +PATHFIX_MAKEFILEIN=3D Makefile MAKE_ENV+=3D CONFIG_SHARED=3Dyes +MAKE_ARGS+=3D INCLUDEDIR=3D"${PREFIX}/include" LIBDIR=3D"${PREFIX}/lib" +LIBS+=3D -lm =20 USE_LDCONFIG=3D yes =20 =2Dpost-patch: =2D ${REINPLACE_CMD} -e 's;INCLUDEDIR;MYINCLUDEDIR;g' \ =2D -e 's;$$(LIBDIR)/pkgconfig;$$(PREFIX)/libdata/pkgconfig;' \ =2D -e 's;LIBDIR;MYLIBDIR;g' \ =2D ${WRKSRC}/dcadec.pc.in \ =2D ${WRKSRC}/Makefile =2D post-install: ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/dcadec ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/${PORTNAME}.so.0.1.0 Index: multimedia/libdcadec/distinfo =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- multimedia/libdcadec/distinfo (revision 411417) +++ multimedia/libdcadec/distinfo (working copy) @@ -1,2 +1,2 @@ =2DSHA256 (foo86-dcadec-0.2.0-v0.2.0_GH0.tar.gz) =3D ed9d207fde3e8d576f3af8= b0d1235b3371e315175757173689104efcaebf0d44 =2DSIZE (foo86-dcadec-0.2.0-v0.2.0_GH0.tar.gz) =3D 225305 +SHA256 (foo86-dcadec-v0.2.0_GH0.tar.gz) =3D ed9d207fde3e8d576f3af8b0d1235b= 3371e315175757173689104efcaebf0d44 +SIZE (foo86-dcadec-v0.2.0_GH0.tar.gz) =3D 225305 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJW7ZkCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bXy8H/RXcxaAN9Aa+Ymh/yCWuu0/4 o5Tryw0uTglX7R03o7qzAEhrs96wXcxm5GhTv6po4xBcxbxou8Py4mztPXGrHsuP /+wdzuE/3+STG/ISpQtS8nAebEudrDPjm+CftAiaI0fbcf9RU4NLozLpCPbe5yHx HOPx2rQzENCyDvQqfCX4xLdBVbZy1IaF0jvrRBktG/x93R/IHTMtWJ+g2qTuns+H CYBDgsLwmnrUrDXS61XxbIKJijCdGXBX5eBK6kKgRRNmFgG85ATuDjNAo3LMv/9Q NiyOXjA/etFYVGCpA+N+EwkRfO0RudW2qn7NraAfUjcm2KMqGvLXPrGw5XWkDiQ= =k2Je -----END PGP SIGNATURE----- --=-=-=--