From owner-svn-src-all@freebsd.org Sat May 12 05:15:54 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7256FAF87B; Sat, 12 May 2018 05:15:53 +0000 (UTC) (envelope-from gonzo@FreeBSD.org) Received: from id.bluezbox.com (id.bluezbox.com [45.55.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6270A7E7DF; Sat, 12 May 2018 05:15:52 +0000 (UTC) (envelope-from gonzo@FreeBSD.org) Received: from localhost ([127.0.0.1] helo=id.bluezbox.com) by id.bluezbox.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1 (FreeBSD)) (envelope-from ) id 1fHMsh-00028K-Uo; Fri, 11 May 2018 22:15:44 -0700 Received: (from gonzo@localhost) by id.bluezbox.com (8.15.2/8.15.2/Submit) id w4C5Fhla008202; Fri, 11 May 2018 22:15:43 -0700 (PDT) (envelope-from gonzo@FreeBSD.org) X-Authentication-Warning: id.bluezbox.com: gonzo set sender to gonzo@FreeBSD.org using -f Date: Fri, 11 May 2018 22:15:43 -0700 From: Oleksandr Tymoshenko To: Ian Lepore Cc: "Jonathan T. Looney" , Stephen Hurd , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r333503 - stable/11/sys/net Message-ID: <20180512051543.GA8131@bluezbox.com> References: <201805112040.w4BKeQvO053076@repo.freebsd.org> <1526081817.2597.5.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1526081817.2597.5.camel@freebsd.org> X-Operating-System: FreeBSD/11.1-RELEASE-p4 (amd64) User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: Ian Lepore (ian@freebsd.org) wrote: > On Fri, 2018-05-11 at 19:31 -0400, Jonathan T. Looney wrote: > > On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd wrote: > > > > > > > > > Author [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 May 2018 05:15:54 -0000 Ian Lepore (ian@freebsd.org) wrote: > On Fri, 2018-05-11 at 19:31 -0400, Jonathan T. Looney wrote: > > On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd wrote: > > > > > > > > > Author: shurd > > > Date: Fri May 11 20:40:26 2018 > > > New Revision: 333503 > > > URL: https://svnweb.freebsd.org/changeset/base/333503 > > > > > > Log: > > >   MFC r333329, r333366, r333373 > > > > > >   r333329: Fix off-by-one error requesting tx interrupt > > >   r333366: Cleanup queues when iflib_device_register fails > > >   r333373: Log iflib_tx_structures_setup failure in function > > > > > Is this an acceptable style for MFC logs? > > > > I'm asking because I actually prefer this to reading (or compiling) the > > concatenated log messages from several changes. However, I never knew it > > was acceptable to summarize like this. If it is, I'd like to know so I can > > adopt it for run-of-the-mill MFCs. > > > > Jonathan > > This used to be my preferred format, essentially to summarize what's > being mfc'd. But then I started using the MFC Tracker tool [*] and it > automatically generates a commit message that contains the full text, > so I stopped trying to summarize things. I've just deployed new mfctracker version with summarized MFC commit message support so users can now switch between full MFC log and a short version. Of course it's only useful if selected commits have one-line summary in the first line of a commit message. > [*] https://mfc.kernelnomicon.org/6/ > > -- Ian -- gonzo