From owner-freebsd-mobile  Sat Jul 28 19:49:59 2001
Delivered-To: freebsd-mobile@freebsd.org
Received: from sj-msg-core-1.cisco.com (sj-msg-core-1.cisco.com [171.71.163.11])
	by hub.freebsd.org (Postfix) with ESMTP id C0F4537B403
	for <freebsd-mobile@FreeBSD.ORG>; Sat, 28 Jul 2001 19:49:53 -0700 (PDT)
	(envelope-from raj@cisco.com)
Received: from mira-sjcm-2.cisco.com (mira-sjcm-2.cisco.com [171.69.24.14])
	by sj-msg-core-1.cisco.com (8.11.3/8.9.1) with ESMTP id f6T2nkg16898;
	Sat, 28 Jul 2001 19:49:46 -0700 (PDT)
Received: from kitab.cisco.com (kitab.cisco.com [171.69.187.233])
	by mira-sjcm-2.cisco.com (Mirapoint)
	with ESMTP id AEK04214;
	Sat, 28 Jul 2001 19:49:39 -0700 (PDT)
Received: (from raj@localhost)
	by kitab.cisco.com (8.11.0/8.9.2) id f6T2ncP17712;
	Sat, 28 Jul 2001 19:49:38 -0700 (PDT)
	(envelope-from raj)
From: Richard Johnson <raj@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15203.31167.563563.519827@kitab.cisco.com>
Date: Sat, 28 Jul 2001 19:49:35 -0700
To: Nick Sayer <nsayer@quack.kfu.com>
Cc: SXren Schmidt <sos@freebsd.dk>, Robert Sexton <robert@kudra.com>,
	freebsd-mobile@FreeBSD.ORG
Subject: Re: ATA idle spindown patch.
In-Reply-To: <3B635732.6030409@quack.kfu.com>
References: <200107280841.f6S8fvR80063@freebsd.dk>
	<3B6354F9.2070801@quack.kfu.com>
	<3B635732.6030409@quack.kfu.com>
X-Mailer: VM 6.90 under 20.4 "Emerald" XEmacs  Lucid
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-mobile.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-mobile>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-mobile>
X-Loop: FreeBSD.org

Nick Sayer writes:
 > Nick Sayer wrote:
 > 
 > 
 > > 
 > > I tried to put it in ad_reinit(), but that seems to be causing panics at 
 > > resume. The theory was that ad_reinit() seems to be called at resume time.
 > 
 > 
 > I spoke too soon. I just had to use ATA_WAIT_READY instead of ATA_WAIT_INTR.
 > 
 > So I have the same patch as the one that was posted, but I duplicated 
 > the 'if ( ata_suspend > 0 )' block at the end if ad_reinit() with 
 > ATA_WAIT_READY instead of ATA_WAIT_INTR. With that, spindown survives 
 > suspend/resume (well, on resume the drive spins up, obviously, but then 
 > after the wait time it spins back down).

Cool!  I also tried adding it to ad_reinit() but with the same
result.  I never got so far as to try ATA_WAIT_READY.  I'll have to
try that.  Thanks!

/raj

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message