From owner-svn-src-all@FreeBSD.ORG Sun May 16 22:03:09 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80FD2106566B; Sun, 16 May 2010 22:03:09 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from adsum.doit.wisc.edu (adsum.doit.wisc.edu [144.92.197.210]) by mx1.freebsd.org (Postfix) with ESMTP id 517228FC14; Sun, 16 May 2010 22:03:09 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth1.wiscmail.wisc.edu by smtpauth1.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) id <0L2J00D00998TQ00@smtpauth1.wiscmail.wisc.edu>; Sun, 16 May 2010 17:03:08 -0500 (CDT) Received: from comporellon.tachypleus.net ([unknown] [76.210.66.137]) by smtpauth1.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) with ESMTPSA id <0L2J000H7996MS40@smtpauth1.wiscmail.wisc.edu>; Sun, 16 May 2010 17:03:07 -0500 (CDT) Date: Sun, 16 May 2010 17:03:06 -0500 From: Nathan Whitehorn In-reply-to: <4BF067D9.3030602@freebsd.org> To: Marius Strobl Message-id: <4BF06B9A.7000402@freebsd.org> X-Spam-Report: AuthenticatedSender=yes, SenderIP=76.210.66.137 X-Spam-PmxInfo: Server=avs-12, Version=5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2010.5.16.215415, SenderIP=76.210.66.137 References: <201005161557.o4GFv0Lf046659@svn.freebsd.org> <20100516213822.GA49967@alchemy.franken.de> <4BF067D9.3030602@freebsd.org> User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.9) Gecko/20100407 Thunderbird/3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r208152 - in head/sys: dev/ofw powerpc/aim powerpc/ofw X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 May 2010 22:03:09 -0000 On 05/16/10 16:47, Nathan Whitehorn wrote: > On 05/16/10 16:38, Marius Strobl wrote: >> On Sun, May 16, 2010 at 03:57:00PM +0000, Nathan Whitehorn wrote: >>> Author: nwhitehorn >>> Date: Sun May 16 15:56:59 2010 >>> New Revision: 208152 >>> URL: http://svn.freebsd.org/changeset/base/208152 >>> >>> Log: >>> On PowerMac11,2 and (presumably) PowerMac12,1, we need to quiesce >>> the >>> firmware in order to take over control of the SMU. Without doing >>> this, >>> the firmware background process doing fan control will run amok >>> as we >>> take over the system and crash the management chip. >>> >>> This is limited to these two machines because our kernel is heavily >>> dependent on firmware accesses, and so quiescing firmware can cause >>> nasty problems. >>> >> Given that the "quiesce" service isn't part of the Open Firmware >> standard nor of one of its supplements as far as I can see and >> given this service isn't available on sun4u I'd prefer this >> implementation to be entirely moved to MD parts instead (similar >> to the "SUNW," services which we keep MD). > > This is tricky on PowerPC, because there are 3 OF implementations in > use (native virtual-mode, 32-bit virtual mode, and 32-bit real mode), > and it has to go in all of them. I'll try to come up with a > non-horrible way to put this in the MD code, and I won't MFC this > change in the meantime. > -Nathan Immediately after writing this, I realized I had tricked myself into thinking it was hard. Since this is called very early on, in the context set up by Open Firmware, none of those distinctions matter. It's been pulled back in to PPC-specific code in revision 208172. -Nathan