From owner-p4-projects@FreeBSD.ORG  Mon Mar  6 00:24:11 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id EF31F16A423; Mon,  6 Mar 2006 00:24:10 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AD1D116A420
	for <perforce@freebsd.org>; Mon,  6 Mar 2006 00:24:10 +0000 (GMT)
	(envelope-from scottl@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7A19C43D45
	for <perforce@freebsd.org>; Mon,  6 Mar 2006 00:24:10 +0000 (GMT)
	(envelope-from scottl@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k260OAOF098194
	for <perforce@freebsd.org>; Mon, 6 Mar 2006 00:24:10 GMT
	(envelope-from scottl@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k260OA16098191
	for perforce@freebsd.org; Mon, 6 Mar 2006 00:24:10 GMT
	(envelope-from scottl@freebsd.org)
Date: Mon, 6 Mar 2006 00:24:10 GMT
Message-Id: <200603060024.k260OA16098191@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	scottl@freebsd.org using -f
From: Scott Long <scottl@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 92825 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Mar 2006 00:24:11 -0000

http://perforce.freebsd.org/chv.cgi?CH=92825

Change 92825 by scottl@scottl-junior on 2006/03/06 00:23:26

	Define LOCKING_WORKED_AS_IT_SHOULD.  It doesn't work, but this is a
	starting point.  Note that the locking semantics in here are NOT how
	it will work in the future.

Affected files ...

.. //depot/projects/scottl-camlock/src/sys/dev/mpt/mpt.h#6 edit
.. //depot/projects/scottl-camlock/src/sys/dev/mpt/mpt_pci.c#6 edit

Differences ...

==== //depot/projects/scottl-camlock/src/sys/dev/mpt/mpt.h#6 (text+ko) ====

@@ -636,8 +636,8 @@
 }
 
 #else
+#define LOCKING_WORKED_AS_IT_SHOULD
 #ifdef	LOCKING_WORKED_AS_IT_SHOULD
-#error "Shouldn't Be Here!"
 #define	MPT_IFLAGS		INTR_TYPE_CAM | INTR_ENTROPY | INTR_MPSAFE
 #define	MPT_LOCK_SETUP(mpt)						\
 		mtx_init(&mpt->mpt_lock, "mpt", NULL, MTX_DEF);		\

==== //depot/projects/scottl-camlock/src/sys/dev/mpt/mpt_pci.c#6 (text+ko) ====