Date: Thu, 28 Aug 2014 12:18:54 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: cs@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r366438 - head/security/pond Message-ID: <53FF647E.8050101@FreeBSD.org> In-Reply-To: <201408281657.s7SGvpds046492@svn.freebsd.org> References: <201408281657.s7SGvpds046492@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kpl7cKbLHshUlsVJllOgtdAlQP47bGvRf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable BROKEN is only for marking a port that does not build. Normally only used by portmgr to mark a port that should not even be attempted to build because it is known broken; or to stop the user wasting time fetching/building something that will just break linking for example. If the code is dangerous then you should use another mechanism to make sure the user is aware. We don't do this kind of thing in other -devel ports though so I don't think it's really needed here. You could add a non-default OPTION that the user must select to build. Then conventionalize the IGNORE with it. On 8/28/2014 11:57 AM, Antoine Brodin wrote: > Author: antoine > Date: Thu Aug 28 16:57:50 2014 > New Revision: 366438 > URL: http://svnweb.freebsd.org/changeset/ports/366438 > QAT: https://qat.redports.org/buildarchive/r366438/ >=20 > Log: > Remove bad usage of BROKEN > =20 > With hat: portmgr >=20 > Modified: > head/security/pond/Makefile >=20 > Modified: head/security/pond/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/security/pond/Makefile Thu Aug 28 16:57:40 2014 (r366437) > +++ head/security/pond/Makefile Thu Aug 28 16:57:50 2014 (r366438) > @@ -21,7 +21,7 @@ RUN_DEPENDS=3D tor:${PORTSDIR}/security/to > LIB_DEPENDS=3D libgtkspell.so:${PORTSDIR}/textproc/gtkspell \ > libtspi.so:${PORTSDIR}/security/trousers > =20 > -BROKEN=3D Experimental. Know what you do! > +IGNORE=3D Experimental. Know what you do! > PLIST_FILES=3D bin/server bin/client > USE_GNOME=3D gtk30 > GO_PKGNAME=3D github.com/agl/pond >=20 --=20 Regards, Bryan Drewery --kpl7cKbLHshUlsVJllOgtdAlQP47bGvRf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJT/2SCAAoJEDXXcbtuRpfP3akIALtA9tAKM+wH6cOwX/6cmef3 tA23HXbYthoVNf6f1b9isp3s+znZTBntIwjNc1hz5mFaxAJn9gU/taxwEXCbWqef TKj2XaWgdX8rrW7TXuu2MgK/OUqIGPxl1Q7wYo9YMC9c9WZ173/G/5q7JbC33aR2 9IEJvOiUxNODGfyD61I5+uR0TQ5ar0Z9gj0ExIlfX4mMf/5jud+DsrJmpdc2kbRu 42V+VZjNmW2vJuoBmUJy8291HlcZ5SzJgpMMMVj1VrD6b8d6qnGTC11Oh9kwwBT0 nh9BnL1n4AUNcq3ZcufE8y9fqjB9EHJ90JEmTknivuRQynI5wQwu9vMoZmiBCnw= =SXBy -----END PGP SIGNATURE----- --kpl7cKbLHshUlsVJllOgtdAlQP47bGvRf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53FF647E.8050101>