Date: Thu, 7 Mar 2019 08:36:25 -0600 From: Kyle Evans <kevans@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Diane Bruce <db@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r494945 - in head/comms/wsjtx: . files Message-ID: <CACNAnaHaRCRc1umoj9NBbpDEwBOa=0vXRui4B8iZrKHUYZ6YjQ@mail.gmail.com> In-Reply-To: <20190307135631.GA68662@FreeBSD.org> References: <201903071345.x27Dj4Gv030049@repo.freebsd.org> <20190307135631.GA68662@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 7, 2019 at 7:56 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:
>
> On Thu, Mar 07, 2019 at 01:45:04PM +0000, Diane Bruce wrote:
> [... snip ...]
> > Added:
> > head/comms/wsjtx/files/hamlib.patch (contents, props changed)
> > head/comms/wsjtx/files/wsjtx.patch (contents, props changed)
> > ...
> > +post-patch:
> > + ${CP} ${FILESDIR}/wsjtx.patch ${WRKSRC}
> > + ${CP} ${FILESDIR}/hamlib.patch ${WRKSRC}
>
> Can't these be converted to normal patch-* files?
>
This situation is actually a little annoying- patches of these names
exist in the distfile that are 0-length and applied by the wsjtx build
(at some point? I didn't check the exact timing -- perhaps during
config). Doing it this way serves dual purpose:
1.) It works around a bug in our patch that doesn't like 0-length patches, and
2.) It allows the patch to happen in the build's normal workflow.
#1 being the more important one, to which this is a fairly clean
solution. I've changed the behavior in head to match GNU patch
behavior, but it's not likely worth an EN.
Thanks,
Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHaRCRc1umoj9NBbpDEwBOa=0vXRui4B8iZrKHUYZ6YjQ>