From owner-cvs-src@FreeBSD.ORG Tue Oct 5 18:00:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7ABB716A4D7; Tue, 5 Oct 2004 18:00:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0387643D46; Tue, 5 Oct 2004 18:00:31 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i95I0Ucf066526; Tue, 5 Oct 2004 18:00:30 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i95I0UQJ066525; Tue, 5 Oct 2004 18:00:30 GMT (envelope-from jhb) Message-Id: <200410051800.i95I0UQJ066525@repoman.freebsd.org> From: John Baldwin Date: Tue, 5 Oct 2004 18:00:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern subr_turnstile.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2004 18:00:48 -0000 jhb 2004-10-05 18:00:30 UTC FreeBSD src repository Modified files: sys/kern subr_turnstile.c Log: Add a critical section in turnstile_unpend() from before dropping the turnstile chain lock until after making all the awakened threads runnable. First, this fixes a priority inversion race. Second, this attempts to finish waking up all of the threads waiting on a turnstile before doing a preemption. Reviewed by: Stephan Uphoff (who found the priority inversion race) Revision Changes Path 1.149 +2 -0 src/sys/kern/subr_turnstile.c