From owner-freebsd-current  Thu Mar 27 16:10:25 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id QAA05294
          for current-outgoing; Thu, 27 Mar 1997 16:10:25 -0800 (PST)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id QAA05287
          for <current@freebsd.org>; Thu, 27 Mar 1997 16:10:21 -0800 (PST)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id LAA10496; Fri, 28 Mar 1997 11:02:10 +1100
Date: Fri, 28 Mar 1997 11:02:10 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199703280002.LAA10496@godzilla.zeta.org.au>
To: bde@zeta.org.au, nate@mt.sri.com
Subject: Re: dumpfs patch for review
Cc: current@freebsd.org, mpp@freefall.freebsd.org
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

>> It's still ugly.
>
>It's better than nothing...

It's worse than not printing the new fields.

>> >+ 	    afs.fs_id[1], ctime((time_t *)&afs.fs_id[0]));
>>                                 ^^^^^^^^^^
>> 
>> Bogus cast.  Just as wrong as the one in fsirand.c.
>
>Since fs_id[0] is declared as int_32, I have to cast it to time_t in
>order for it to be 'right' (according to fsirand).

As I said, fsirand is wrong too.  It converts the pointer, not the object.
If time_t is 64 bits then the pointer would probably point to 32 bits of
data and 32 bits of garbage.

>> The minfree...maxbpg line shouldn't be changed.
>
>Why not change them?  We had to change something?

Nothing was broken in that line.

>> I'm now convinced that the old fields shouldn't have been reused.  The above
>> changes give wrong output on old and foreign file systems.
>
>Yep, but in order to remain compatible with the other *BSd's, we must
>either convince them to use the other 'unused' fields.

That would be easier than rewriting history :-).

Bruce