Date: Fri, 28 Mar 1997 11:02:10 +1100 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, nate@mt.sri.com Cc: current@freebsd.org, mpp@freefall.freebsd.org Subject: Re: dumpfs patch for review Message-ID: <199703280002.LAA10496@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> It's still ugly. > >It's better than nothing... It's worse than not printing the new fields. >> >+ afs.fs_id[1], ctime((time_t *)&afs.fs_id[0])); >> ^^^^^^^^^^ >> >> Bogus cast. Just as wrong as the one in fsirand.c. > >Since fs_id[0] is declared as int_32, I have to cast it to time_t in >order for it to be 'right' (according to fsirand). As I said, fsirand is wrong too. It converts the pointer, not the object. If time_t is 64 bits then the pointer would probably point to 32 bits of data and 32 bits of garbage. >> The minfree...maxbpg line shouldn't be changed. > >Why not change them? We had to change something? Nothing was broken in that line. >> I'm now convinced that the old fields shouldn't have been reused. The above >> changes give wrong output on old and foreign file systems. > >Yep, but in order to remain compatible with the other *BSd's, we must >either convince them to use the other 'unused' fields. That would be easier than rewriting history :-). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703280002.LAA10496>