From owner-freebsd-virtualization@freebsd.org Thu Jan 16 11:18:10 2020 Return-Path: Delivered-To: freebsd-virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BBBB42334B4 for ; Thu, 16 Jan 2020 11:18:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 47z1ry4d0Xz3MR6 for ; Thu, 16 Jan 2020 11:18:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 9EB702334B3; Thu, 16 Jan 2020 11:18:10 +0000 (UTC) Delivered-To: virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9E7EF2334B2 for ; Thu, 16 Jan 2020 11:18:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47z1ry3nKqz3MR5 for ; Thu, 16 Jan 2020 11:18:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 64EE91E8A7 for ; Thu, 16 Jan 2020 11:18:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00GBIAgs038394 for ; Thu, 16 Jan 2020 11:18:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00GBIARN038393 for virtualization@FreeBSD.org; Thu, 16 Jan 2020 11:18:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 236922] Virtio fails as QEMU-KVM guest with Q35 chipset on Ubuntu 18.04.2 LTS Date: Thu, 16 Jan 2020 11:18:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: drum@graphica.com.au X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2020 11:18:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236922 --- Comment #44 from John Hartley --- (In reply to Tommy P from comment #43) Hi Tommy P, thanks again for continuing to work on this. I have applied a slight variation to what you posted, which did: #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) Conditional compilation rather than remove the netmap code. See diffs here: # diff sys/dev/virtio/network ~/virtio-12/sys/dev/virtio/network diff sys/dev/virtio/network/if_vtnet.c /home/jbh/virtio-12/sys/dev/virtio/network/if_vtnet.c 350c350 < #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) --- > #ifdef DEV_NETMAP 367c367 < #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) --- > #ifdef DEV_NETMAP 475c475 < #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) --- > #ifdef DEV_NETMAP 507c507 < #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) --- > #ifdef DEV_NETMAP 2031c2031 < #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) --- > #ifdef DEV_NETMAP 2766c2766 < #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) --- > #ifdef DEV_NETMAP 3070c3070 < #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) --- > #ifdef DEV_NETMAP 3218c3218 < #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) --- > #ifdef DEV_NETMAP 3409c3409 < #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) --- > #ifdef DEV_NETMAP diff sys/dev/virtio/network/if_vtnetvar.h /home/jbh/virtio-12/sys/dev/virtio/network/if_vtnetvar.h 85c85 < #if defined(DEV_NETMAP) & defined(WITH_PTNETMAP) --- > #ifdef DEV_NETMAP 124c124 < #if defined(DEV_NETMAP) && defined(WITH_PTNETMAP) This is just a suggestion as it allows for easy "re-enablement" of netmap in the event that Vincenzo re-adds "#define WITH_PTNETMAP" into sys/dev/netmap/netmap_kern.h netmap parameter file. In my testing I got clean compile across your, Brian's and Vincenzo's updat= es, but did not get any VirtIO devices showing up :-( . This is likely due to either: a. me having incorrectly apply update or other issue, due to all my add/removing and patching code b. some other QEMU / Q35 version issues (which MattS has reported on other defect thread). Cheers, John Hartley. --=20 You are receiving this mail because: You are the assignee for the bug.=