Date: Sat, 20 Dec 1997 20:12:32 +1100 (EST) From: John Birrell <jb@cimlogic.com.au> To: bde@zeta.org.au (Bruce Evans) Cc: grog@lemis.com, julian@whistle.com, bde@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Bruce vandalism again Message-ID: <199712200912.UAA00292@freebsd1.cimlogic.com.au> In-Reply-To: <199712200839.TAA23072@godzilla.zeta.org.au> from Bruce Evans at "Dec 20, 97 07:39:50 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote: > >I agree. This appears to be a seriously retrograde step. Bruce, why? > > I'm just enforcing this part of style(9): > > Only use the __P macro from the include file <sys/cdefs.h> if the source > file in general is (to be) compilable with a K&R Old testament compiler. > Use of the __P macro in new code is discouraged, although modifications > to existing files should be consistent with that file's conventions. If the use of the __P macro in new code is discouraged, then FreeBSD is not trying to keep K&R compatibility (like NetBSD insists on). So we are *encouraging* ANSI prototypes. Then (IMO) code that is being edited (for other reasons) should have its function definitions changed to ANSI style at the same time, regardless of how much code is regarded as new according to this silly statement..... > In general code can be considered ``new code'' when it makes up about 50% > or more of the file[s] involved. This is enough to break precedents in > the existing code and use the current style guidelines. Now is that 50% of the code that makes up the function definitions or do we have to count all the other lines of code too?! OK, so it's nearly Christmas (the silly season), and Jordan headed of the last potential flame war about tcl, so I thought I'd light another one. *Chuckle* > > Bruce > Regards, -- John Birrell - jb@cimlogic.com.au; jb@netbsd.org; jb@freebsd.org CIMlogic Pty Ltd, GPO Box 117A, Melbourne Vic 3001, Australia +61 418 353 137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712200912.UAA00292>