From owner-freebsd-ports@FreeBSD.ORG Thu Jan 28 21:17:07 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 827B31065672 for ; Thu, 28 Jan 2010 21:17:07 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [IPv6:2001:470:a803::1]) by mx1.freebsd.org (Postfix) with ESMTP id C2CAF8FC1B for ; Thu, 28 Jan 2010 21:16:57 +0000 (UTC) Received: from mail.geekcn.org (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id 40AC2A5D475; Fri, 29 Jan 2010 05:16:54 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by mail.geekcn.org (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with LMTP id k4gL3E4j4tk8; Fri, 29 Jan 2010 05:16:47 +0800 (CST) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id F0EC4A5D377; Fri, 29 Jan 2010 05:16:46 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:subject:references:in-reply-to:x-enigmail-version:openpgp: content-type:content-transfer-encoding; b=tAFWC3lSRJh+lUZJK1pcHbcXI/05Zt2IuqQM8RxGXnuLmwFJbEvTqaB/A5uEKQIdu cSk7Kw+NUppRJzWcC+YkA== Message-ID: <4B61FEBB.7050503@delphij.net> Date: Thu, 28 Jan 2010 13:16:43 -0800 From: Xin LI Organization: The Geek China Organization User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.7) Gecko/20100122 Thunderbird/3.0.1 ThunderBrowse/3.2.8.1 MIME-Version: 1.0 To: freebsd-ports@freebsd.org References: <4B61E988.1000801@missouri.edu> In-Reply-To: <4B61E988.1000801@missouri.edu> X-Enigmail-Version: 1.0 OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: patch upgrade for port committers? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2010 21:17:07 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2010/01/28 11:46, Stephen Montgomery-Smith wrote: > When an update to a port is committed, it is likely to contain > > (a) lines like "Only in xxxx: yyyy" > > or (b) patches that are created against empty files using the "-N" > option for diff. > > Cannot "patch" honor these cases? As a port maintainer, I have been > caught quite a few times by committers not adding or removing files from > the "files" directory in a port. For patch to remove files one can specify -E; I think ports committers are responsible to take care for adding/removing files. It's advisable for committers to do 'portlint - -C' and a full 'port test' (porttools) run at minimum... Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iQEcBAEBAgAGBQJLYf67AAoJEATO+BI/yjfB830H/il+N/9xzGfECkPYdErNhHIF yCRgvrXWqcRv8fy8O2cg0I3reXacxADj9ex+sl4o8wVKBuAJJQv0zSvhBTVIaxyl bsWThyqf523AE70qmfew2vtsH8nCf4lZVwI9relVpvOOgcCAZcC5Tjj04HU+nbcl 9c/HJJdQmfZcIsYOEU7K38aX7Ip7hgX/JzkZ1gPQWwLH+XdKAkruChjk3vKbbBFy ZG2EnevcZDwC4e1/354x+1imTg2Jh2BYDuU0eXHnaVfkYInmjHEvE12w5Mtxy8H1 SLQw4mEz1F51TedgUd2uWSY7j91K24AQzo/q99D2C2GYlA/ZX/AJyBVPP2bFXRY= =/7DD -----END PGP SIGNATURE-----