From owner-svn-ports-all@freebsd.org Fri Mar 30 16:12:57 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D1AFF78129; Fri, 30 Mar 2018 16:12:57 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f42.google.com (mail-lf0-f42.google.com [209.85.215.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 790D36EF68; Fri, 30 Mar 2018 16:12:56 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f42.google.com with SMTP id g203-v6so13105946lfg.11; Fri, 30 Mar 2018 09:12:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NlN3saPiasJTkhtQeaw7vScnc9ht9cRVmwvqPWWkEW8=; b=FLDqN0Yghmmo1i2my9NV2SpOIf99Pf9DedPt+lAhdDJaIix6lJKOM4cN7DcRX9PYLF 06Fp0683aTeODvzWWVp9AhYQNXTQGr5EZy1z0Cio2aIMw9q/UxJRxIy3o4lm32gE7/TX F2Xw2V9dn4ggjEZV2HNdyQBIaQzpZ12gNfvofsuQBeJuWV/0ZWgd1t3Fe6OuKkHpykRx x+Xo2bbr9052CCuj7vINvZUP9r95RQ9+dUcRFJ5QRj2AlFLX0skicYFLdRQCs6IR3ohs E7DjX0XnCX7zb7QXRd9ecfAzli2hiEfSzvGz2/ZDuPxQL1x+Wk8/HFRxYnYRpHrmOmq5 PxyA== X-Gm-Message-State: AElRT7F0OJGIQk53wItZ4fxJaGKMa+vxceXGpEJz5k1e3TDDFUT0amJB j76J5HmxuZhlvy8g/SjDptXh6uPS X-Google-Smtp-Source: AIpwx4/648z7gIxQ9odyf093m+ckKsUittLb0wXR+awgQvP11rIRYEJfTUWFU8HAKMc+1MEFE5AJjA== X-Received: by 10.46.53.11 with SMTP id z11mr8226926ljz.69.1522426369176; Fri, 30 Mar 2018 09:12:49 -0700 (PDT) Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com. [209.85.215.49]) by smtp.gmail.com with ESMTPSA id 17sm1406003ljr.66.2018.03.30.09.12.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Mar 2018 09:12:49 -0700 (PDT) Received: by mail-lf0-f49.google.com with SMTP id t132-v6so13145189lfe.2; Fri, 30 Mar 2018 09:12:49 -0700 (PDT) X-Received: by 10.46.153.147 with SMTP id w19mr5001667lji.93.1522426368883; Fri, 30 Mar 2018 09:12:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.129.90 with HTTP; Fri, 30 Mar 2018 09:12:28 -0700 (PDT) In-Reply-To: <201803232353.w2NNrqnJ028176@repo.freebsd.org> References: <201803232353.w2NNrqnJ028176@repo.freebsd.org> From: Kyle Evans Date: Fri, 30 Mar 2018 11:12:28 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r465416 - in head/devel: aarch64-gcc amd64-gcc mips-gcc mips64-gcc powerpc64-gcc sparc64-gcc To: John Baldwin Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 16:12:57 -0000 On Fri, Mar 23, 2018 at 6:53 PM, John Baldwin wrote: > Author: jhb (src,doc committer) > Date: Fri Mar 23 23:53:52 2018 > New Revision: 465416 > URL: https://svnweb.freebsd.org/changeset/ports/465416 > > Log: > Fix --sysroot for cross-toolchain GCC packages > > By default, GCC assumes that a cross compiler should not have any valid > initial include or library paths aside from /usr/local/lib/gcc//. > This means that one cannot use --sysroot to point to a system root for > another architecture and have GCC automatically look for headers in > ${sysroot}/usr/include, etc. Currently we workaround this in FreeBSD's > build system with explicit -isystem, -B, and -L directives. However, > this is cumbersome compared to clang (where a bare --sysroot DTRT) > especially when using the compiler to build other software (such as test > programs, etc.). > > One can override GCC's assumption and force it to assume that it should > honor --sysroot by setting the '--with-sysroot' option to force GCC to > assume a specific system root. By setting this to '/', this means that > the cross-compiler will attempt to use the host's headers by default > if --sysroot is not specified, but if --sysroot is specified then > it is fully honored including for include paths and library paths. With > this change I can now cross-compile both C and C++ binaries simply by > using --sysroot without the need for -isystem, -B, or -L directives. Note > that the base/gcc and devel/riscv64-gcc ports both use --with-sysroot='/' > already. > > By default, GCC looks for headers in /usr/local/include (under the > sysroot) before /usr/include. To disable this and only look for headers > in /usr/include, patch gcc/Makefile.in to not define LOCAL_INCLUDE_DIR. > > Once -nostdinc is no longer required, the headers installed along with the > compiler are now used for compiling worlds and test programs. The "fixed" > headers in include-fixed are generally not helpful and are also derived > from the host's headers which might not match the target --sysroot, so > just delete them entirely. Even the stub limits.h headers GCC ships when > using an empty build sysroot are not helpful and need to be removed. > > On a related note, I also fixed the name of the C++ include directory > option to configure. By my reading it is 'with-gxx-include-dir' rather > than 'with-gcc-include-dir'. > > Reviewed by: bapt, brooks, kan > Sponsored by: DARPA / AFRL > Differential Revision: https://reviews.freebsd.org/D14627 > > Modified: > head/devel/aarch64-gcc/pkg-plist > head/devel/amd64-gcc/pkg-plist > head/devel/mips-gcc/pkg-plist > head/devel/mips64-gcc/pkg-plist > head/devel/powerpc64-gcc/Makefile > head/devel/powerpc64-gcc/pkg-plist > head/devel/sparc64-gcc/pkg-plist > Hey John, Documentation is eluding me here- what was --with-sysroot before? For other applications, is there a way to force the old behavior while invoking gcc? This appears to have caused arm-none-eabi-newlib to fail to build [1], I guess because it's pulling in a different (our limits.h?) without some LONG_LONG_MAX definitions that it needs. I can patch it to use LLONG_ instead of LONG_LONG_, but I have mixed feelings about compiling it in this new world order rather than the old world order that it's been tested in and expects. Thanks, Kyle Evans [1] http://package19.nyi.freebsd.org/data/103i386-default-build-as-user/465853/logs/arm-none-eabi-newlib-2.4.0_1.log