From owner-freebsd-fs@freebsd.org Mon Feb 15 03:39:01 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2EC725471B9 for ; Mon, 15 Feb 2021 03:39:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Df8wP0fSsz3FBS for ; Mon, 15 Feb 2021 03:39:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 13A1B547234; Mon, 15 Feb 2021 03:39:01 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 124305472AA for ; Mon, 15 Feb 2021 03:39:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Df8wN6xnlz3FQD for ; Mon, 15 Feb 2021 03:39:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D705816A22 for ; Mon, 15 Feb 2021 03:39:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F3d06e056232 for ; Mon, 15 Feb 2021 03:39:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F3d05q056231 for fs@FreeBSD.org; Mon, 15 Feb 2021 03:39:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 03:39:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 03:39:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #37 from Konstantin Belousov --- (In reply to Cy Schubert from comment #36) Ok, I can (partially) understand it. Below are two patches. I believe that either one of them should fix the problem. Can you check please? [Both are needed for correctness] commit 83a450af9edfd1b5ca705e8101870109225fdc7d Author: Konstantin Belousov Date: Mon Feb 15 05:36:02 2021 +0200 UFS snapshots: properly set the vm object size. PR: 253158 diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c index 8f0adde6f5e4..6da84fb46bb0 100644 --- a/sys/ufs/ffs/ffs_snapshot.c +++ b/sys/ufs/ffs/ffs_snapshot.c @@ -59,6 +59,9 @@ __FBSDID("$FreeBSD$"); #include #include +#include +#include + #include #include @@ -328,6 +331,7 @@ ffs_snapshot(mp, snapfile) goto out; bawrite(bp); ip->i_size =3D lblktosize(fs, (off_t)(numblks + 1)); + vnode_pager_setsize(vp, ip->i_size); DIP_SET(ip, i_size, ip->i_size); UFS_INODE_SET_FLAG(ip, IN_SIZEMOD | IN_CHANGE | IN_UPDATE); /* commit 7b34e5b278f9f2af69f5d39f7999507a17238293 Author: Konstantin Belousov Date: Mon Feb 15 05:34:06 2021 +0200 pgcache read: protect against reads past end of the vm object size If uio_offset is past end of the object size, calculated resid is negat= ive. Delegate handling this case to the locked read, as any other non-trivial situation. PR: 253158 diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 46b333b2261f..b13eb442e436 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -967,6 +967,8 @@ vn_read_from_obj(struct vnode *vp, struct uio *uio) #else vsz =3D atomic_load_64(&obj->un_pager.vnp.vnp_size); #endif + if (uio->uio_offset >=3D vsz) + goto out; if (uio->uio_offset + resid > vsz) resid =3D vsz - uio->uio_offset; --=20 You are receiving this mail because: You are the assignee for the bug.=