From owner-svn-src-head@FreeBSD.ORG Mon Mar 14 19:38:24 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CDA80106566B; Mon, 14 Mar 2011 19:38:24 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id DBF1F8FC0C; Mon, 14 Mar 2011 19:38:23 +0000 (UTC) Received: by wyf23 with SMTP id 23so5617729wyf.13 for ; Mon, 14 Mar 2011 12:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=oAOGTfgRxJEHz6k7Z453DDdApBf0Arh++mWtav/G3Kk=; b=rhvt1EIq5zjwbAQjLTZ6aRHLlmHePDvGMuc3sR503lJMAo+NVGzOY4NiMhGPPqekJT hjvbXQ8PISLEBYtUP35/EnOPNNvLIyZP9cMBNw8/mmKU4B/7h7TlZxMdxYj/qsWnWSCk cMGBt7bRUlto3wfVQzoxlWQhkIBC0INHyJWxY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=m7ymhgeCVrd8hCYOZk1bSruw/SGcOpbKkFJtkyCxEFryav+uvO1FTcEYkJ8MIwfJG1 jRS/muLA+LvuIMSYWbou4PdlT+U0etaOfskMbUatV/R9FL9Pu7KetrrcdIDVBHtw2sdi yomT+twsBFelb4TGooJLVLLSTNZtYI/8u1tdw= MIME-Version: 1.0 Received: by 10.216.191.208 with SMTP id g58mr5328924wen.85.1300131502642; Mon, 14 Mar 2011 12:38:22 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.216.173.142 with HTTP; Mon, 14 Mar 2011 12:38:22 -0700 (PDT) In-Reply-To: <201101191704.p0JH47ZS082977@svn.freebsd.org> References: <201101191704.p0JH47ZS082977@svn.freebsd.org> Date: Mon, 14 Mar 2011 12:38:22 -0700 X-Google-Sender-Auth: wyi5vXghf1THEKxiy_WNbLjxtRI Message-ID: From: Garrett Cooper To: Matthew D Fleming Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217586 - in head: sbin/sysctl share/man/man9 sys/cam/scsi sys/dev/cxgb sys/dev/wi sys/net sys/sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2011 19:38:24 -0000 On Wed, Jan 19, 2011 at 9:04 AM, Matthew D Fleming wrote: > Author: mdf > Date: Wed Jan 19 17:04:07 2011 > New Revision: 217586 > URL: http://svn.freebsd.org/changeset/base/217586 > > Log: > =A0sysctl(8) should use the CTLTYPE to determine the type of data when > =A0reading. =A0(This was already done for writing to a sysctl). =A0This > =A0requires all SYSCTL setups to specify a type. =A0Most of them are now > =A0checked at compile-time. > > =A0Remove SYSCTL_*X* sysctl additions as the print being in hex should be > =A0controlled by the -x flag to sysctl(8). I appreciate the work, but this really should have been followed up by a __FreeBSD_version__ bump, as this unfortunately broke some ports like emulators/*qemu*. I just filed a PR for it as I noticed it when doing portmaster -af for the recent X.org upgrade. FWIW, this can be properly tested with: __FreeBSD_version__ < 900031; kib bumped the version a week after this commit. Thanks, -Garrett