From owner-trustedbsd-discuss@FreeBSD.ORG Thu Mar 9 14:08:49 2006 Return-Path: X-Original-To: trustedbsd-discuss@FreeBSD.org Delivered-To: trustedbsd-discuss@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF7F016A420; Thu, 9 Mar 2006 14:08:49 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36BE543D48; Thu, 9 Mar 2006 14:08:49 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id A6BE846BCC; Thu, 9 Mar 2006 09:08:26 -0500 (EST) Date: Thu, 9 Mar 2006 14:09:09 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Hiroki Sato In-Reply-To: <20060308.015844.98687889.hrs@allbsd.org> Message-ID: <20060309140712.L13591@fledge.watson.org> References: <20060308.015844.98687889.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: trustedbsd-discuss@FreeBSD.org Subject: Re: question about MAC policy modules on 6.0 X-BeenThere: trustedbsd-discuss@FreeBSD.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: TrustedBSD General Discussion List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2006 14:08:49 -0000 On Wed, 8 Mar 2006, Hiroki Sato wrote: > 4) mount_ufs(8) multilabel option > > mount_ufs(8) has multilabel option for the MAC label, but it > seems broken ("tunefs -l enable" works, though). I am not sure > the attached patch (the second one) is correct, but it should > fix this. It's been a while since I've looked at this code, and have not had a chance to test your patch as yet. The desired behavior is that mount be able to report that multilabel is set on the file system, and request that it be set when mounting the file system, but that the flag cannot be changed while running. The cache model on vnode labels basically means we assume the underlying label storage won't change except through the supported MAC APIs, and the mechanisms are not in place to walk the current vnode list to re-synchronize if the backing store changes (i.e., is enabled). So as long as your patch doesn't add the ability to modify the flag at run-time, it sounds good to me. In principle the kernel shouldn't allow it regardless of what mount requests, of course. Robert N M Watson