From nobody Sun Oct 27 16:33:10 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xc2BZ2h2hz5bBb1; Sun, 27 Oct 2024 16:33:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xc2BZ1F42z4PCr; Sun, 27 Oct 2024 16:33:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730046790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sZlTP04RjlbeG+Xr9fEnBuGXhFs/W3jTr8znqtR+svk=; b=dYZMwZx7HHMwzLRDq1Jl0n6nLxqf23R7IEL1xMQ5EHT1vJffsuPmjt1YvvsOi2iJLlrZQU TUy/ik4IQK/8pYFte0sgBvni/BNZjs61ia43AEigkgsGw3CswGvXxfhqweFt9jN8XHdHHi D2SWIpsTnghlQV+tMTiPQBGo6P+pgOk1lFLqzFW2zWGDAMipTwBaJ/Na7xZSGONKiN72cu o8BzsX+gWgGKCfSjoY6Q8DaS2/32aLJ1boJEA75DR64jo0o2BqlnRjT6nRnzPWyyF9soy3 /0/MA6eHe6+zIAziIwCunm2OAINGJK6Te6Rx7qK7PpzZBaxCUAZ5K1Ira1t5fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730046790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sZlTP04RjlbeG+Xr9fEnBuGXhFs/W3jTr8znqtR+svk=; b=x2xeHieYU2Z8GIkKGKwDrykIM+Ptg9k2ZJUUe96CYe7+gKhm/az12aKAiW2VdzQQOoLzqd 9ahhsX30UpxrxVhK9WcfzShjHuN4PvQYscpEPl3xwSTUH1D8cIjojsFq2Zd1Um4Q8aKTPk ai7nfFwfb1HBF3XA+zst9UH9I/aWAG0arkdV4fC10gyvh4DD6EFpX4Zx35Gw8R51HxqbNJ AilssQmp2RahiZXIu+ufK5PYYdiNSSoaJUgNTRXYMqBywvdhySltz2bMK/6dMuhoqOmpup ktmmy8GweHxnyA+yOLnGdwFQtjUB5w7SskYkzITw9NgXE4Y59r99X/kJuBXvBQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730046790; a=rsa-sha256; cv=none; b=eaTPvqxKegf+JgglWV8tzlSFLI0PhRA/jmXTmBfHmebPcqsnX+2GxgVSi0cRA1LSjpdA3g yaxRTU/JvySoFeckWDoLAs7/7WOut8cVCtvbTi6Bf/ZpSOX+hhkbIzHfxsBFEYrGHTRhkr eszB9J/eRfVYA24ECRlqZAWJ9q1XlVJ98zJTt4e31F1LUgJrhP8toRBoaycm2likuocSoh dSwaG93DkdPmJMARwNVjD0lGeLOXhP185uqSNb5t9UFQuaU3sACEA8rffUmp+gXjniM0rw hWmFej5QV/aoCMgtlV2PFSG8alkbkTAEP5FfcBhc6AGX9ZHuvendZ2l3vgeNRQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xc2BZ0rGyz12K9; Sun, 27 Oct 2024 16:33:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49RGXATH035366; Sun, 27 Oct 2024 16:33:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49RGXAfj035363; Sun, 27 Oct 2024 16:33:10 GMT (envelope-from git) Date: Sun, 27 Oct 2024 16:33:10 GMT Message-Id: <202410271633.49RGXAfj035363@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 32a2994b4487 - stable/14 - sound: Use DSP_REGISTERED in dsp_clone() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 32a2994b4487d9de5190982fd88cbc6d57414cdb Auto-Submitted: auto-generated The branch stable/14 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=32a2994b4487d9de5190982fd88cbc6d57414cdb commit 32a2994b4487d9de5190982fd88cbc6d57414cdb Author: Christos Margiolis AuthorDate: 2024-10-24 11:37:10 +0000 Commit: Christos Margiolis CommitDate: 2024-10-27 16:32:16 +0000 sound: Use DSP_REGISTERED in dsp_clone() DSP_REGISTERED calls PCM_REGISTERED, and already contains all the checks we are doing. No functional change intended. Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: dev_submerge.ch, markj Differential Revision: https://reviews.freebsd.org/D47196 (cherry picked from commit bb5e3ac1a7b71480a50fc0c813c916a3d058336c) --- sys/dev/sound/pcm/dsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/sound/pcm/dsp.c b/sys/dev/sound/pcm/dsp.c index 6573dfaabf2f..92bfb4d58b86 100644 --- a/sys/dev/sound/pcm/dsp.c +++ b/sys/dev/sound/pcm/dsp.c @@ -1967,7 +1967,7 @@ found: * have returned already, meaning it will have set snd_unit to -1, and * thus devclass_get_softc() will return NULL here. */ - if (d != NULL && PCM_REGISTERED(d) && d->dsp_dev != NULL) { + if (DSP_REGISTERED(d)) { *dev = d->dsp_dev; dev_ref(*dev); }