From owner-freebsd-current@freebsd.org Fri Apr 24 19:23:32 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BEE6C2C0383 for ; Fri, 24 Apr 2020 19:23:32 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4983xH6FY2z420R; Fri, 24 Apr 2020 19:23:31 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f53.google.com with SMTP id k6so11603395iob.3; Fri, 24 Apr 2020 12:23:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lxLzRzZImuNi/75hvR800wvZoAXFWL8UXDh+s+L0bmc=; b=psaYhGQ7+GT3dlJOoPmRW0DCY//qqAkZfGyJ3I1ctbZVH+eySKIYIoHgbhoW6MPXDC k5/Cphbm4VJjQkdmY8SLCJY5JqrwEUKzPO4LtORI4+7Dvxxy28Qy/E2jBpRz7vqLrUFt iovipeBHDoHXTaVAt72ztQGdanuhXUyjLm5jJL1vT6MLKwn0+f7kjWtVEdDkgKPIBYex biSxyoad2eNJXURLHMpQNxCAODhAlUUZ+ZQEhnny6fNfHMyMy8xWCx0M/qLNKvGlFyzv 9JrjBULjiBn2ihDrrtUQWiTYymbJpsVZ9sJw3WEG2rqMCABxNnhozYFm24rn/a0bNjDv ZdXA== X-Gm-Message-State: AGi0PuYih6fVRQ+q+qFS0j1Xn+k8LvpE3r5HXcxfhbQUq43wWqUlrTln RN73urkjHAnDV6RBRawMplhLoWxXI6MJGn4dpU8= X-Google-Smtp-Source: APiQypI7gOmXin5g8bAr+o6E0y4uu+jci1Oxbv41yed4yev+V9WP2O9/dcx6lsR3AnEwPBZpcqZbrviSzX5U1DiBOi8= X-Received: by 2002:a05:6638:247:: with SMTP id w7mr9787749jaq.128.1587756210635; Fri, 24 Apr 2020 12:23:30 -0700 (PDT) MIME-Version: 1.0 References: <202004171047.03HAlFk6050161@gndrsh.dnsmgr.net> <20200424132144.7b0bb922@fabiankeil.de> In-Reply-To: <20200424132144.7b0bb922@fabiankeil.de> From: Ed Maste Date: Fri, 24 Apr 2020 15:23:18 -0400 Message-ID: Subject: Re: Ordering of files in zoneinfo To: Fabian Keil Cc: Xin LI , Johan Hendriks , FreeBSD Current , Brooks Davis , "M. Warner Losh" , Glen Barber , Bryan Drewery , Brad Davis Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4983xH6FY2z420R X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-1.14 / 15.00]; ARC_NA(0.00)[]; SUSPICIOUS_RECIPS(1.50)[]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_HAM_MEDIUM(-0.98)[-0.977,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; MIME_TRACE(0.00)[0:+]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; RCVD_IN_DNSWL_NONE(0.00)[53.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.66)[ip: (-2.45), ipnet: 209.85.128.0/17(-0.40), asn: 15169(-0.43), country: US(-0.05)]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_CC(0.00)[gmail.com] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 19:23:32 -0000 On Fri, 24 Apr 2020 at 07:23, Fabian Keil wrote: > > > I wonder if we could drop the sort and replace ${TZS} in line 100 with > > ${TZS:O} instead? > > Makes sense to me. Agreed, that seems sensible. > > By the way, looking at > > https://github.com/freebsd/pkg/blob/master/libpkg/metalog.c , I wonder if > > the sort should really happen in pkg(8) instead? > > Currently the METALOG is also used when creating the tarballs so sorting > only in pkg would be insufficient as long as tarballs are still supported. I think there are other reasons we'd like to keep METALOG itself in deterministic order too, even if pkg can take care of it -- for example, issues like PR234886 can be triggered by ordering (even though the root cause is elsewhere and TZ ordering isn't going to lead to exactly that kind of issue).