Date: Fri, 24 Apr 2020 15:23:18 -0400 From: Ed Maste <emaste@freebsd.org> To: Fabian Keil <freebsd-listen@fabiankeil.de> Cc: Xin LI <delphij@gmail.com>, Johan Hendriks <joh.hendriks@gmail.com>, FreeBSD Current <freebsd-current@freebsd.org>, Brooks Davis <brooks@freebsd.org>, "M. Warner Losh" <imp@freebsd.org>, Glen Barber <gjb@freebsd.org>, Bryan Drewery <bdrewery@freebsd.org>, Brad Davis <brd@freebsd.org> Subject: Re: Ordering of files in zoneinfo Message-ID: <CAPyFy2D1jQdHy0LRULpnZ0QCrgy0EGJ%2BRsd4rxe8pet3GQnKFQ@mail.gmail.com> In-Reply-To: <20200424132144.7b0bb922@fabiankeil.de> References: <202004171047.03HAlFk6050161@gndrsh.dnsmgr.net> <f2e0f78b-32be-a5f3-b885-737be6ddbfd6@gmail.com> <e933c7c1-5068-dc9a-e4e3-77b004ccf8cd@gmail.com> <CAGMYy3sw8Jb=SCL=qK%2BQVfuc379fJSSU-nLT1REO-Ncs7r1oCg@mail.gmail.com> <20200424132144.7b0bb922@fabiankeil.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 24 Apr 2020 at 07:23, Fabian Keil <freebsd-listen@fabiankeil.de> wrote:
>
> > I wonder if we could drop the sort and replace ${TZS} in line 100 with
> > ${TZS:O} instead?
>
> Makes sense to me.
Agreed, that seems sensible.
> > By the way, looking at
> > https://github.com/freebsd/pkg/blob/master/libpkg/metalog.c , I wonder if
> > the sort should really happen in pkg(8) instead?
>
> Currently the METALOG is also used when creating the tarballs so sorting
> only in pkg would be insufficient as long as tarballs are still supported.
I think there are other reasons we'd like to keep METALOG itself in
deterministic order too, even if pkg can take care of it -- for
example, issues like PR234886 can be triggered by ordering (even
though the root cause is elsewhere and TZ ordering isn't going to lead
to exactly that kind of issue).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2D1jQdHy0LRULpnZ0QCrgy0EGJ%2BRsd4rxe8pet3GQnKFQ>