Date: Mon, 10 Mar 2014 20:29:20 +0100 From: =?UTF-8?B?UmVuw6kgTGFkYW4=?= <rene@freebsd.org> To: Lei Zhang <thestig@google.com>, "Torne (Richard Coles)" <torne@chromium.org> Cc: chromium-packagers@chromium.org, chromium@freebsd.org Subject: Re: [chromium-packagers] more thoughts on porting Chromium to FreeBSD Message-ID: <531E1290.2020202@freebsd.org> In-Reply-To: <CACSHbcSqDzQvkgWGGDLhX1KNg47OQK=jXJvYOrs6QqqVAmg1Ow@mail.gmail.com> References: <531D83D1.2050005@freebsd.org> <CAEV-rjdoJg7%2BUvC8Mtdy4xGHz5BdVAEq%2BNUrponhXNQrboeV=Q@mail.gmail.com> <531DE49E.8000207@freebsd.org> <CAEV-rjf7t6CY_VWczfGhp25EUQyTjSUd%2BA4pphfE7YbHH2n=mw@mail.gmail.com> <CACSHbcSqDzQvkgWGGDLhX1KNg47OQK=jXJvYOrs6QqqVAmg1Ow@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/10/2014 18:22, Lei Zhang wrote: > On Mon, Mar 10, 2014 at 9:59 AM, Torne (Richard Coles) > <torne@chromium.org> wrote: >> On 10 March 2014 16:13, René Ladan <rene@freebsd.org> wrote: >>> Hm, there does not seem to be a hard rule here. Somehow having dedicated >>> _freebsd files looks cleaner but that does impose more work. >> >> It might look cleaner but if there are cases where the code in _freebsd >> would be basically the same, or literally identical, then this makes >> maintaining the codebase much harder. Duplication is bad :) > There is no hard rule. Use your best judgement on this. If the FreeBSD > implementation is completely different, or if trying to share code > with other POSIX implementations lead to #ifdef hell, then it might > make sense to break out the code into a _freebsd file. Yes, that would make the most sense I think. > In base/ there is a base/nix directory that's POSIX but not Mac. > However, the convention has no spread to other parts of the source > code. No, only files related to xdg there. > Also, you may want to have this discussion on chromium-dev with a > wider audience, rather than chromium-packagers. > Heh, I suggested that in the private mail but then ti was suggested to send it to chromium-packagers instead. René
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?531E1290.2020202>