From owner-svn-ports-all@freebsd.org Fri Nov 6 11:41:15 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7D8EC2EC4A8; Fri, 6 Nov 2020 11:41:15 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CSJPR2vXnz3QL7; Fri, 6 Nov 2020 11:41:15 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: by mail-qk1-x731.google.com with SMTP id i21so704174qka.12; Fri, 06 Nov 2020 03:41:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HQE55n619jGuByUMd184EzI0Dt3AkUY7bqH+iH46/uQ=; b=YDRXYMmdcLxBuq+Y3ShfqZWXDuemS3JNRSrV9HQA4hk6FLVOR4ChQJeGKn/A2rUA1d j6MUDzlTz8PLDxLvQqiuhZUgcc2lDZOayEsssPYg3OIPD9q4LoCcSO/YzS/Qr4zVKY2B auveY7Gj0OI5KzxIfUKUg6KqCsLw7SUKSzqb+yEP+Bgt1rRgNI5pB34y6CNYNGIOIjBd /jjVubB+bij6AVOmuq3pw6MDZGQDjAz20LMjVXSi26xcgIR63kuPWi1Hj43WLIWdjNkH 7vmx3HqYzoPYimiTKcyq2vyKdeFW8kPrppm4xUJ2qLcwI5ig6+VI5g5lfyENPTV7Dp+6 nVQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HQE55n619jGuByUMd184EzI0Dt3AkUY7bqH+iH46/uQ=; b=nwDIyYCKVudc4E+SFNWogCqS8hr0Ku0ifB7KzNRiVZRoyQfMAHAPmvtMafkb7tQq8I BhdAjILo4oH1cTrcSqps5cejCNieRTv0NUMAfdgfD0jUQpmW5Ww8QRnPHGpE5b7TIU/s Wh/NBt7FbYVqsawQqN+lMZErCAX0Jy4JUqPAC1BuZkIb7bypPVenwmOKt9jHbExLpRKW csdtmPuoMZAA2Vap+NgAxQgq0PEb4Dp9Nyg7DHeJ+Mm4NZI/pdddSLM+LHwUu+Arygli 3ia29pZK5Ok6stowatNdRURDAmV5sj6tD0+w998Xsv2KeNG9WrKOWGp1P6HrIIehRrys wPCg== X-Gm-Message-State: AOAM530ywVIeUz0VHLSZfdWoxmpaabKX9cjk5fa3LSyOxieXzviAl25e T9xz+brfKJXs9SLL+HKeVkKwy+Aj/gA= X-Google-Smtp-Source: ABdhPJyepNiH2FeRuUZxA+zSUeo9NjghrESglIhLBaQOFWKQkGBsQo4zu9A46dGOFnhBR0Aebu+OBw== X-Received: by 2002:a37:d244:: with SMTP id f65mr990371qkj.124.1604662873992; Fri, 06 Nov 2020 03:41:13 -0800 (PST) Received: from mbp.home ([2804:f1c:7300:cb00:6c16:78c2:5bfb:11a8]) by smtp.gmail.com with ESMTPSA id w5sm324289qkf.31.2020.11.06.03.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Nov 2020 03:41:13 -0800 (PST) Sender: Renato Botelho Subject: Re: svn commit: r554143 - head/devel/git To: Guido Falsi , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202011051704.0A5H4Jf8010250@repo.freebsd.org> From: Renato Botelho Message-ID: <1ef8c98e-49e4-3aff-2886-4991d264ab2f@FreeBSD.org> Date: Fri, 6 Nov 2020 08:41:09 -0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4CSJPR2vXnz3QL7 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 11:41:15 -0000 On 06/11/20 04:22, Guido Falsi wrote: > On 05/11/20 18:04, Renato Botelho wrote: >> Author: garga >> Date: Thu Nov  5 17:04:19 2020 >> New Revision: 554143 >> URL: https://svnweb.freebsd.org/changeset/ports/554143 >> >> Log: >>    devel/git: Update to 2.29.2 and small tweaks >>    - Update to 2.29.2 [1] >>    - Simplify logic to define COMMENT for each flavor >>    - Inspired in www/py-autobahn, save OPTIONS on a different file for >> each flavor >>    PR:        250472 [1] >>    Submitted by:    Yasuhiro KIMURA [1] >>    Sponsored by:    Rubicon Communications, LLC (Netgate) >> >> Modified: >>    head/devel/git/Makefile >>    head/devel/git/distinfo >>    head/devel/git/pkg-plist >> >> Modified: head/devel/git/Makefile >> ============================================================================== >> >> --- head/devel/git/Makefile    Thu Nov  5 16:51:30 2020    (r554142) >> +++ head/devel/git/Makefile    Thu Nov  5 17:04:19 2020    (r554143) >> @@ -2,7 +2,7 @@ >>   # $FreeBSD$ > [...] >> @@ -76,6 +73,8 @@ OPTIONS_EXCLUDE=    GUI SVN GITWEB CONTRIB P4 CVS PERL >>   .endif >>   OPTIONS_SUB=    yes >> + >> +OPTIONS_FILE=        ${PORT_DBDIR}/${OPTIONS_NAME}/${FLAVOR}-options > > I'm not sure why, but this is not working as expected IMHO. > > I noticed that, when using "poudriere options" and building with > "poudriere bulk" the options file is ignored. poudsriere option > continuously brings up the git dialog4ports screen and asks options > proposing the defaults. The option file is correctly written but never > read. poudriere bulk ignores it and builds with default options. I never used `poudriere options` before and indeed it seems to have a bug there. For some reason I didn't understand yet poudriere considers git (with default flavor) as a dependency of git (with lite or gui flavor) and it's not correct. I tested a build with `poudriere testport -c -j JAIL devel/git@lite` and changed some options. It worked as expected as you can see at [1]. > Also on the local machine running make config repeatedly in the port > directory does the same: the dialog4ports sscreen comes up with default > options each time and the options file is written but never read. I made lots of tests here and everything worked. The way I did it was using: # make FLAVOR=(lite|gui) [config|showconfig|rmconfig] and I couldn't reproduce any issue. Every time selected options were respected by showconfig, which reads file saved on config step. > Am I missing something? is something special required for this to > actually work? [1] https://bast.garga.net.br/data/13-amd64-default/2020-11-06_08h23m56s/logs/git-lite-2.29.2.log -- Renato Botelho