From owner-freebsd-arch@FreeBSD.ORG  Fri Mar 14 14:20:28 2014
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7142B1EA
 for <freebsd-arch@FreeBSD.org>; Fri, 14 Mar 2014 14:20:28 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5A12D1000
 for <freebsd-arch@FreeBSD.org>; Fri, 14 Mar 2014 14:20:28 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s2EEKSgn017600
 for <freebsd-arch@FreeBSD.org>; Fri, 14 Mar 2014 14:20:28 GMT
 (envelope-from bdrewery@freefall.freebsd.org)
Received: (from bdrewery@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s2EEKSQ7017599
 for freebsd-arch@FreeBSD.org; Fri, 14 Mar 2014 14:20:28 GMT
 (envelope-from bdrewery)
Received: (qmail 11477 invoked from network); 14 Mar 2014 09:20:22 -0500
Received: from unknown (HELO roundcube.xk42.net) (10.10.5.5)
 by sweb.xzibition.com with SMTP; 14 Mar 2014 09:20:22 -0500
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Fri, 14 Mar 2014 09:20:22 -0500
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: freebsd-arch@FreeBSD.org
Subject: Renaming cnt to =?UTF-8?Q?vm=5Fcnt?=
Organization: FreeBSD
Message-ID: <1627768f8d03e34c68dbe72038033a2d@shatow.net>
X-Sender: bdrewery@FreeBSD.org
User-Agent: Roundcube Webmail/0.9.5
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Mar 2014 14:20:28 -0000

Hi,

http://people.freebsd.org/~bdrewery/patches/cnt_vm_cnt.diff

I would like to rename the vmmeter.h global cnt to vm_cnt.
It is quite a generic variable to be polluting the global
namespace. The variable is only defined in _KERNEL, so
there is no userland/KBI risk. We've made this same
change at Isilon as well.

The only downside I see is that it will cause conflicts
when merging from project branches and pending patches.
It also will essentially need to be redone for MFC
with a direct commit.

I don't think any conflicts would be painful though.

Is anyone strongly against such a change?

I generated with: sed -i '' -e 's,[[:<:]]cnt[[:>:]]\.v_,vm_cnt.v_,g' 
$(git grep -l "[[:<:]]cnt[[:>:]]\.")
I have not yet ran make universe to check if it is
sufficient/proper, but will before commit of course.

-- 
Regards,
Bryan Drewery