From owner-cvs-share  Tue Apr  2 11:07:53 1996
Return-Path: owner-cvs-share
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id LAA16412
          for cvs-share-outgoing; Tue, 2 Apr 1996 11:07:53 -0800 (PST)
Received: from ki.net (root@ki.net [205.150.102.1])
          by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id LAA16383
          Tue, 2 Apr 1996 11:07:43 -0800 (PST)
Received: from localhost (scrappy@localhost) by ki.net (8.7.4/8.7.4) with SMTP id OAA13903; Tue, 2 Apr 1996 14:07:23 -0500 (EST)
Date: Tue, 2 Apr 1996 14:07:17 -0500 (EST)
From: "Marc G. Fournier" <scrappy@ki.net>
To: Bruce Evans <bde@zeta.org.au>
cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-share@freefall.freebsd.org, scrappy@freefall.freebsd.org
Subject: Re: cvs commit:  src/share/man/man9 devfs_add_devswf.9 Makefile devfs_link.9 devfs_add_devsw.9
In-Reply-To: <199604021252.WAA15288@godzilla.zeta.org.au>
Message-ID: <Pine.BSI.3.92.960402135845.13100F-100000@ki.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-share@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Tue, 2 Apr 1996, Bruce Evans wrote:

> >  Modified:    share/man/man9  Makefile devfs_link.9
> >  Added:       share/man/man9  devfs_add_devswf.9
> >  Removed:     share/man/man9  devfs_add_devsw.9
> >  Log:
> >  Makefile: added devfs_add_devswf.9, removed devfs_add_devsw.9
> >
> >  devfs_link.9: modified man page to reflect source code
> >
> >  devfs_add_devsw.9: replaced by devfs_add_devswf.9
> >
> >  devfs_add_devswf.9: proper function for adding devices to DEVFS
>
> Joerg must want to kill section 9 to choose the devfs functions for
> documenting first :-).  devfs is under active development and its
> external interface was inconvenient and wrong so it was certain to
> change.  Now it is wrong and is certain to change :-).
>
	No, actually, now it should be right...

> The next step is to finish the changes so that the code matches the man
> pages.  devfs_link() is misdeclared in devfsext.h.  Stuff involving the
> link function has been broken for several days because of the confusing
> names (dev_link vs dev_linkf vs devfs_link).
>
	devfs_link() prototype will be fixed before you get this...or
should be, depending on how my link feels like acting today :(

> Future interface changes should include:
> - nuke devfs_add_devsw and rename devfs_add_devswf to devfs_add_devsw

	Being worked on.  Everything is switched from using devfs_add_devsw,
so once I get the new root drive for my main machine installed and my -current
box back up again, will get to work on that.

> - rename devfs_add_devsw to something shorter

	something shorter?

> - nuke the uid, gid and permissions args to devfs_add_devsw.  Drivers
>   shouldn't decide policy.

	So...how would the kernel know what permissions to set on the
devices?  And where would you set them?

Marc G. Fournier | POP Mail  Telnet Acct  DNS Hosting
System           |  WWW Services   Database Services  | Knowledge,
  Administrator  |                                    | Information and
 scrappy@ki.net  |      WWW: http://www.ki.net        | Communications, Inc